[bisect] - Add --path_to_config parameter to run script.

tools/run-bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Run Performance Test Bisect Tool
 
 This script is used by a trybot to run the src/tools/bisect-perf-regression.py
 script with the parameters specified in run-bisect-perf-regression.cfg. It will
 check out a copy of the depot in a subdirectory 'bisect' of the working
@@ skipping 351 matching lines @@
   parser = optparse.OptionParser(usage=usage)
   parser.add_option('-w', '--working_directory',
                     type='str',
                     help='A working directory to supply to the bisection '
                     'script, which will use it as the location to checkout '
                     'a copy of the chromium depot.')
   parser.add_option('-p', '--path_to_goma',
                     type='str',
                     help='Path to goma directory. If this is supplied, goma '
                     'builds will be enabled.')
+  parser.add_option('--path_to_config',
+                    type='str',
+                    help='Path to the config file to use. If this is supplied, '
+                    'the bisect script will use this to override the default '
+                    'config file path.')
   parser.add_option('--extra_src',
                     type='str',
                     help='Path to extra source file. If this is supplied, '
                     'bisect script will use this to override default behavior.')
   parser.add_option('--dry_run',
                     action="store_true",
                     help='The script will perform the full bisect, but '
                     'without syncing, building, or running the performance '
                     'tests.')
   (opts, args) = parser.parse_args()
 
   path_to_current_directory = os.path.abspath(os.path.dirname(sys.argv[0]))
-  path_to_bisect_cfg = os.path.join(path_to_current_directory,
-      'run-bisect-perf-regression.cfg')
+
+  # If they've specified their own config file, use that instead.
+  if opts.path_to_config:
+    path_to_bisect_cfg = opts.path_to_config

[prasadv, 2014/04/09 23:17:51]

Should'n we validate whether the path_to_config is file and if it exists? or the
format of the content?

[shatch, 2014/04/10 17:32:54]

Done.

+  else:
+    path_to_bisect_cfg = os.path.join(path_to_current_directory,
+        'run-bisect-perf-regression.cfg')
 
   config = _LoadConfigFile(path_to_bisect_cfg)
 
   # Check if the config is empty
   config_has_values = [v for v in config.values() if v]
 
   if config and config_has_values:
     if not opts.working_directory:
       print 'Error: missing required parameter: --working_directory'
       print
@@ skipping 19 matching lines @@
             opts.path_to_goma)
 
     print 'Error: Could not load config file. Double check your changes to '\
           'run-bisect-perf-regression.cfg/run-perf-test.cfg for syntax errors.'
     print
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())