Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2320823003: cc/blimp: Remove Initialize and Close messages. (Closed)

Created:
4 years, 3 months ago by Khushal
Modified:
4 years, 3 months ago
Reviewers:
nyquist, vmpstr
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc/blimp: Remove Initialize and Close messages. The BlimpCompositor has a 1:1 mapping with the RenderWidgetCompositor, there is no need for explicit create methods for the LayerTreeHost. Next change will pull blimp specific code from BlimpCompositor to a higher layer. BUG=644326 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149 Cr-Commit-Position: refs/heads/master@{#417453}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : fix tests #

Patch Set 4 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -170 lines) Patch
M blimp/client/core/compositor/blimp_compositor.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 4 chunks +3 lines, -20 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_unittest.cc View 1 2 2 chunks +0 lines, -36 lines 0 comments Download
M cc/proto/compositor_message_to_impl.proto View 1 chunk +0 lines, -19 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 3 chunks +10 lines, -31 lines 0 comments Download
M cc/test/remote_proto_channel_bridge.h View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/test/remote_proto_channel_bridge.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M cc/test/test_hooks.h View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M cc/trees/remote_channel_main.cc View 2 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Khushal
4 years, 3 months ago (2016-09-07 23:49:45 UTC) #3
nyquist
blimp lgtm
4 years, 3 months ago (2016-09-08 00:58:42 UTC) #4
vmpstr
cc lgtm
4 years, 3 months ago (2016-09-08 01:11:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320823003/1
4 years, 3 months ago (2016-09-08 01:17:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/65523) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 01:19:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320823003/20001
4 years, 3 months ago (2016-09-08 20:15:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/66090) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 20:17:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320823003/60001
4 years, 3 months ago (2016-09-08 23:23:46 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/260289)
4 years, 3 months ago (2016-09-08 23:30:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320823003/60001
4 years, 3 months ago (2016-09-08 23:34:22 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-09 00:36:44 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:39:41 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149
Cr-Commit-Position: refs/heads/master@{#417453}

Powered by Google App Engine
This is Rietveld 408576698