Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: blimp/client/core/compositor/blimp_compositor_unittest.cc

Issue 2320823003: cc/blimp: Remove Initialize and Close messages. (Closed)
Patch Set: format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/compositor/blimp_compositor_unittest.cc
diff --git a/blimp/client/core/compositor/blimp_compositor_unittest.cc b/blimp/client/core/compositor/blimp_compositor_unittest.cc
index 26f1576cdc1d8cc056c1c41e355023efc861479d..f184f95183491beef2d6a8b219cd6fe4f7ad4350 100644
--- a/blimp/client/core/compositor/blimp_compositor_unittest.cc
+++ b/blimp/client/core/compositor/blimp_compositor_unittest.cc
@@ -80,23 +80,6 @@ class BlimpCompositorTest : public testing::Test {
~BlimpCompositorTest() override {}
- void SendInitializeMessage() {
- std::unique_ptr<cc::proto::CompositorMessage> message;
- message.reset(new cc::proto::CompositorMessage);
- cc::proto::CompositorMessageToImpl* to_impl = message->mutable_to_impl();
- to_impl->set_message_type(
- cc::proto::CompositorMessageToImpl::INITIALIZE_IMPL);
- compositor_->OnCompositorMessageReceived(std::move(message));
- }
-
- void SendShutdownMessage() {
- std::unique_ptr<cc::proto::CompositorMessage> message;
- message.reset(new cc::proto::CompositorMessage);
- cc::proto::CompositorMessageToImpl* to_impl = message->mutable_to_impl();
- to_impl->set_message_type(cc::proto::CompositorMessageToImpl::CLOSE_IMPL);
- compositor_->OnCompositorMessageReceived(std::move(message));
- }
-
int render_widget_id_;
std::unique_ptr<base::MessageLoop> loop_;
MockBlimpCompositorClient compositor_client_;
@@ -106,33 +89,14 @@ class BlimpCompositorTest : public testing::Test {
};
TEST_F(BlimpCompositorTest, ToggleVisibilityWithHost) {
- // Make the compositor visible when we don't have a host.
compositor_->SetVisible(true);
- SendInitializeMessage();
// Check that the visibility is set correctly on the host.
- EXPECT_NE(compositor_->host(), nullptr);
EXPECT_TRUE(compositor_->host()->IsVisible());
// Make the compositor invisible. This should make the |host_| invisible.
compositor_->SetVisible(false);
EXPECT_FALSE(compositor_->host()->IsVisible());
-
- SendShutdownMessage();
- EXPECT_EQ(compositor_->host(), nullptr);
-}
-
-TEST_F(BlimpCompositorTest, DestroyAndRecreateHost) {
- // Create the host and make it visible.
- SendInitializeMessage();
- compositor_->SetVisible(true);
-
- // Destroy this host and recreate a new one. Make sure that the visibility is
- // set correctly on this host.
- SendShutdownMessage();
- SendInitializeMessage();
- EXPECT_NE(compositor_->host(), nullptr);
- EXPECT_TRUE(compositor_->host()->IsVisible());
}
TEST_F(BlimpCompositorTest, MessagesHaveCorrectId) {
« no previous file with comments | « blimp/client/core/compositor/blimp_compositor_manager_unittest.cc ('k') | cc/proto/compositor_message_to_impl.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698