Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 2320763002: Support origin-based deletion for password store statistics (Closed)
Patch Set: Mac-specific code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index 250ab15e5af0f066a5bb70fd0fcbc6bbc8c3ecff..94ca6cef22ebe0a666401b8bb7f64fe0c67d75cb 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -142,13 +142,16 @@ class PasswordStore : protected PasswordStoreSync,
void RemoveLoginsSyncedBetween(base::Time delete_begin,
base::Time delete_end);
- // Removes all the stats created in the given date range. If |completion| is
- // not null, it will be posted to the |main_thread_runner_| after deletions
- // have been completed.
+ // Removes all the stats created in the given date range.
+ // If |origin_filter| is not null, only statistics for matching origins are
+ // removed. If |completion| is not null, it will be posted to the
+ // |main_thread_runner_| after deletions have been completed.
// Should be called on the UI thread.
- void RemoveStatisticsCreatedBetween(base::Time delete_begin,
- base::Time delete_end,
- const base::Closure& completion);
+ void RemoveStatisticsByOriginAndTime(
+ const base::Callback<bool(const GURL&)>& origin_filter,
+ base::Time delete_begin,
+ base::Time delete_end,
+ const base::Closure& completion);
// Sets the 'skip_zero_click' flag for all logins in the database that match
// |origin_filter| to 'true'. |completion| will be posted to
@@ -282,8 +285,10 @@ class PasswordStore : protected PasswordStoreSync,
base::Time delete_end) = 0;
// Synchronous implementation to remove the statistics.
- virtual bool RemoveStatisticsCreatedBetweenImpl(base::Time delete_begin,
- base::Time delete_end) = 0;
+ virtual bool RemoveStatisticsByOriginAndTimeImpl(
+ const base::Callback<bool(const GURL&)>& origin_filter,
+ base::Time delete_begin,
+ base::Time delete_end) = 0;
// Synchronous implementation to disable auto sign-in.
virtual PasswordStoreChangeList DisableAutoSignInForOriginsImpl(
@@ -386,9 +391,11 @@ class PasswordStore : protected PasswordStoreSync,
const base::Closure& completion);
void RemoveLoginsSyncedBetweenInternal(base::Time delete_begin,
base::Time delete_end);
- void RemoveStatisticsCreatedBetweenInternal(base::Time delete_begin,
- base::Time delete_end,
- const base::Closure& completion);
+ void RemoveStatisticsByOriginAndTimeInternal(
+ const base::Callback<bool(const GURL&)>& origin_filter,
+ base::Time delete_begin,
+ base::Time delete_end,
+ const base::Closure& completion);
void DisableAutoSignInForOriginsInternal(
const base::Callback<bool(const GURL&)>& origin_filter,
const base::Closure& completion);

Powered by Google App Engine
This is Rietveld 408576698