Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2326)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 2320763002: Support origin-based deletion for password store statistics (Closed)
Patch Set: Mac-specific code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index c97af7539fff947fbff3a2c896e1becf28de3fae..314c1eb26f54450a2d1430b25231cb082b863696 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -152,13 +152,14 @@ void PasswordStore::RemoveLoginsSyncedBetween(base::Time delete_begin,
this, delete_begin, delete_end));
}
-void PasswordStore::RemoveStatisticsCreatedBetween(
+void PasswordStore::RemoveStatisticsByOriginAndTime(
+ const base::Callback<bool(const GURL&)>& origin_filter,
base::Time delete_begin,
base::Time delete_end,
const base::Closure& completion) {
ScheduleTask(
- base::Bind(&PasswordStore::RemoveStatisticsCreatedBetweenInternal, this,
- delete_begin, delete_end, completion));
+ base::Bind(&PasswordStore::RemoveStatisticsByOriginAndTimeInternal, this,
+ origin_filter, delete_begin, delete_end, completion));
}
void PasswordStore::DisableAutoSignInForOrigins(
@@ -424,11 +425,12 @@ void PasswordStore::RemoveLoginsSyncedBetweenInternal(base::Time delete_begin,
NotifyLoginsChanged(changes);
}
-void PasswordStore::RemoveStatisticsCreatedBetweenInternal(
+void PasswordStore::RemoveStatisticsByOriginAndTimeInternal(
+ const base::Callback<bool(const GURL&)>& origin_filter,
base::Time delete_begin,
base::Time delete_end,
const base::Closure& completion) {
- RemoveStatisticsCreatedBetweenImpl(delete_begin, delete_end);
+ RemoveStatisticsByOriginAndTimeImpl(origin_filter, delete_begin, delete_end);
if (!completion.is_null())
main_thread_runner_->PostTask(FROM_HERE, completion);
}

Powered by Google App Engine
This is Rietveld 408576698