Issue 232073005: Addressed comments from review https://codereview.chromium.org/226263007

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
6 years, 8 months ago by andersmholmgren

Modified:
6 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Addressed comments from review https://codereview.chromium.org/226263007 addressed code review comments. Changed extraParams to context BUG=

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -26 lines)			Patch
M	pkg/shelf/lib/src/message.dart	View	1 chunk	+13 lines, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/request.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/response.dart	View	9 chunks	+25 lines, -20 lines	0 comments	Download
M	pkg/shelf/test/request_test.dart	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	pkg/shelf/test/response_test.dart	View	1 chunk	+50 lines, -0 lines	0 comments	Download