issue 17992 Added extra params to message

issue 17992 Added extra params to message
added extra params to message

BUG=17992
Resolved with https://code.google.com/p/dart/source/detail?r=35102

[nweiz, 2014-04-08 21:33:50]

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.dart
File pkg/shelf/lib/src/message.dart (right):

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.da...
pkg/shelf/lib/src/message.dart:26: /// Extra parameters for handlers to pass
data to downstream handlers
I don't know that everyone will have the same intuition for which direction is
"upstream" and which is "downstream". It's especially confusing because during
request handling, this will be passed to inner handlers, but during response
handling it will be passed to outer handlers. Maybe just "other handlers" is
best.

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.da...
pkg/shelf/lib/src/message.dart:30: final Map<String, Object> extraParams;
I like "context" as a name here.

[andersmholmgren, 2014-04-08 22:16:35]

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.dart
File pkg/shelf/lib/src/message.dart (right):

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.da...
pkg/shelf/lib/src/message.dart:26: /// Extra parameters for handlers to pass
data to downstream handlers
On 2014/04/08 21:33:50, nweiz wrote:
> I don't know that everyone will have the same intuition for which direction is
> "upstream" and which is "downstream". It's especially confusing because during
> request handling, this will be passed to inner handlers, but during response
> handling it will be passed to outer handlers. Maybe just "other handlers" is
> best.

My bad, clearly I was thinking of request context when I wrote this comment.
Will amend

https://codereview.chromium.org/226263007/diff/1/pkg/shelf/lib/src/message.da...
pkg/shelf/lib/src/message.dart:30: final Map<String, Object> extraParams;
On 2014/04/08 21:33:50, nweiz wrote:
> I like "context" as a name here.

+1. That's the best name. It came to me a day after submitting this but I
couldn't figure out how to add a comment to my own review.

Other options are handlerContext, appContext etc

[nweiz, 2014-04-10 19:34:40]

Let me know when you upload the amended CL.

[andersmholmgren, 2014-04-10 21:28:15]

On 2014/04/10 19:34:40, nweiz wrote:
> Let me know when you upload the amended CL.

Apologies, I'm not familiar with the CL process and ended up creating a new one
https://codereview.chromium.org/232073005/

Let me know if you need me to figure out how to amend this one instead

[andersmholmgren, 2014-04-10 22:53:01]

On 2014/04/10 19:34:40, nweiz wrote:
> Let me know when you upload the amended CL.

Done

[nweiz, 2014-04-15 22:24:52]

lgtm, I'll merge this in.

[andersmholmgren, 2014-04-16 00:01:08]

On 2014/04/15 22:24:52, nweiz wrote:
> lgtm, I'll merge this in.

cool. Does that mean I'll get my name in the authors? ;-)

[nweiz, 2014-04-16 00:03:22]

On 2014/04/16 00:01:08, andersmholmgren wrote:
> On 2014/04/15 22:24:52, nweiz wrote:
> > lgtm, I'll merge this in.
> 
> cool. Does that mean I'll get my name in the authors? ;-)

We aren't particularly consistent about adding pkg contributors, but sure.

I'm uploading some style changes so kevmoo can take a look.

[andersmholmgren, 2014-04-16 00:08:20]

On 2014/04/16 00:03:22, nweiz wrote:
> On 2014/04/16 00:01:08, andersmholmgren wrote:
> > On 2014/04/15 22:24:52, nweiz wrote:
> > > lgtm, I'll merge this in.
> > 
> > cool. Does that mean I'll get my name in the authors? ;-)
> 
> We aren't particularly consistent about adding pkg contributors, but sure.
> 
> I'm uploading some style changes so kevmoo can take a look.

cool. Thanks :-)