cocoa: give bookmarks menu an accessible title

cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
Committed: https://crrev.com/3fbddcd5c63c21cfa820aa9f36003f91e847d825
Cr-Commit-Position: refs/heads/master@{#417573}

[Elly Fong-Jones, 2016-09-08 14:37:52]

Description was changed from

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
==========

to

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
==========

[Elly Fong-Jones, 2016-09-08 14:37:53]

ellyjones@chromium.org changed reviewers:
+ avi@chromium.org

[Elly Fong-Jones, 2016-09-08 14:38:00]

avi: ptal? :)

[Avi (use Gerrit), 2016-09-08 14:43:30]

I'm heading OOO later. LGTM if you give this a real IDS_ identity with a name
like "Bookmark menu".

https://codereview.chromium.org/2320723006/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm (right):

https://codereview.chromium.org/2320723006/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm:63: return
l10n_util::GetNSString(IDS_ACCNAME_BOOKMARKS_CHEVRON);
But this is "Menu containing hidden bookmarks", which it's not.

[Elly Fong-Jones, 2016-09-09 12:52:51]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-09 12:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2320723006/#ps20001
(title: "add IDS_ACCNAME_BOOKMARKS_MENU")

[commit-bot: I haz the power, 2016-09-09 12:52:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 13:43:48]

Description was changed from

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
==========

to

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
==========

[commit-bot: I haz the power, 2016-09-09 13:43:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 13:45:23]

Description was changed from

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496
==========

to

==========
cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG=641496

Committed: https://crrev.com/3fbddcd5c63c21cfa820aa9f36003f91e847d825
Cr-Commit-Position: refs/heads/master@{#417573}
==========

[commit-bot: I haz the power, 2016-09-09 13:45:24]

Patchset 2 (id:??) landed as
https://crrev.com/3fbddcd5c63c21cfa820aa9f36003f91e847d825
Cr-Commit-Position: refs/heads/master@{#417573}