cocoa: give bookmarks menu an accessible title

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h"
 
 #import "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"
+#include "chrome/grit/generated_resources.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h"
+#include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/material_design/material_design_controller.h"
 
 using bookmarks::kBookmarkBarMenuCornerRadius;
 
 namespace {
 
 // Material Design bookmark folder window background white.
 const CGFloat kMDFolderWindowBackgroundColor = 237. / 255.;
 
 }  // namespace
 
+@interface BookmarkBarFolderWindow (Accessibility)
+
+- (NSString*)accessibilityTitle;
+
+@end
+
 @implementation BookmarkBarFolderWindow
 
 - (id)initWithContentRect:(NSRect)contentRect
                 styleMask:(NSUInteger)windowStyle
                   backing:(NSBackingStoreType)bufferingType
                     defer:(BOOL)deferCreation {
   if ((self = [super initWithContentRect:contentRect
                                styleMask:NSBorderlessWindowMask // override
                                  backing:bufferingType
                                    defer:deferCreation])) {
     [self setBackgroundColor:[NSColor clearColor]];
     [self setOpaque:NO];
   }
   return self;
 }
 
 - (BOOL)canBecomeKeyWindow {
   return YES;
 }
 
 - (BOOL)canBecomeMainWindow {
   return NO;
 }
 
 // Override of keyDown as the NSWindow default implementation beeps.
 - (void)keyDown:(NSEvent *)theEvent {
 }
 
+// This is a little icky. If the menu doesn't have a separate accessibleTitle,
+// it will get announced as its normal window title, which is "BmbPopUpWindow".
+// Instead, reuse the bookmark chevron's label for the menu that it spawns.
+- (NSString*)accessibilityTitle {
+  return l10n_util::GetNSString(IDS_ACCNAME_BOOKMARKS_CHEVRON);

[Avi (use Gerrit), 2016/09/08 14:43:30]

But this is "Menu containing hidden bookmarks", which it's not.

+}
+
 @end
 
 
 @implementation BookmarkBarFolderWindowContentView
 
 + (NSColor*)backgroundColor {
   DCHECK(ui::MaterialDesignController::IsModeMaterial());
   static NSColor* backgroundColor =
       [[NSColor colorWithGenericGamma22White:kMDFolderWindowBackgroundColor
                                        alpha:1.0] retain];
@@ skipping 37 matching lines @@
 // window.  However that also allows some scrollWheel: events to leak
 // into the NSWindow behind it (even in a different application).
 // Better to plug the scroll leak than to round corners for M5.
 - (void)scrollWheel:(NSEvent *)theEvent {
   DCHECK([[[self window] windowController]
            respondsToSelector:@selector(scrollWheel:)]);
   [[[self window] windowController] scrollWheel:theEvent];
 }
 
 @end