Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2320713003: Revert of service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. (patchset #1 id:1 of https://codereview.chromium.org/2318443002/ ) Reason for revert: SWProcessManager is innocent. The CHECKs aren't failing. Original issue's description: > service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. > > We're still not sure where the non-zero ref counts on shutdown come from. > > BUG=636377 > > Committed: https://crrev.com/e7ffbf80d3b612521a7c2564b21b96695586274a > Cr-Commit-Position: refs/heads/master@{#416596} TBR=horo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636377 Committed: https://crrev.com/595fe676755cd28139fc4f7f50102251af8413c5 Cr-Commit-Position: refs/heads/master@{#417472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M content/browser/service_worker/service_worker_process_manager.cc View 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
falken
Created Revert of service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts.
4 years, 3 months ago (2016-09-08 07:28:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320713003/1
4 years, 3 months ago (2016-09-08 07:29:15 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82405)
4 years, 3 months ago (2016-09-08 09:13:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320713003/1
4 years, 3 months ago (2016-09-09 00:33:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 01:26:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 01:29:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/595fe676755cd28139fc4f7f50102251af8413c5
Cr-Commit-Position: refs/heads/master@{#417472}

Powered by Google App Engine
This is Rietveld 408576698