Revert of service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts.

content/browser/service_worker/service_worker_process_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_process_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 175 matching lines @@
   }
 
   if (IsShutdown()) {
     BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                             base::Bind(callback, SERVICE_WORKER_ERROR_ABORT,
                                        ChildProcessHost::kInvalidUniqueID,
                                        false /* is_new_process */, settings));
     return;
   }
 
-  // TODO(falken): Revert to DCHECK. Temporary check for debugging
-  // crbug.com/639193
-  CHECK(!base::ContainsKey(instance_info_, embedded_worker_id))
+  DCHECK(!base::ContainsKey(instance_info_, embedded_worker_id))
       << embedded_worker_id << " already has a process allocated";
 
   if (can_use_existing_process) {
     int process_id = FindAvailableProcess(pattern);
     if (process_id != ChildProcessHost::kInvalidUniqueID) {
       RenderProcessHost::FromID(process_id)->IncrementServiceWorkerRefCount();
       instance_info_.insert(
           std::make_pair(embedded_worker_id, ProcessInfo(process_id)));
       BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
@@ skipping 42 matching lines @@
   }
 
   if (process_id_for_test_ != ChildProcessHost::kInvalidUniqueID) {
     // Unittests don't increment or decrement the worker refcount of a
     // RenderProcessHost.
     return;
   }
 
   if (IsShutdown()) {
     // Shutdown already released all instances.
-    // TODO(falken): Revert to DCHECK. Temporary check for debugging
-    // crbug.com/639193
-    CHECK(instance_info_.empty());
+    DCHECK(instance_info_.empty());
     return;
   }
 
   std::map<int, ProcessInfo>::iterator info =
       instance_info_.find(embedded_worker_id);
   // ReleaseWorkerProcess could be called for a nonexistent worker id, for
   // example, when request to start a worker is aborted on the IO thread during
   // process allocation that is failed on the UI thread.
   if (info == instance_info_.end())
     return;
 
   RenderProcessHost* rph = NULL;
   if (info->second.site_instance.get()) {
     rph = info->second.site_instance->GetProcess();
-    // TODO(falken): Revert to DCHECK. Temporary check for debugging
-    // crbug.com/639193
-    CHECK_EQ(info->second.process_id, rph->GetID())
+    DCHECK_EQ(info->second.process_id, rph->GetID())
         << "A SiteInstance's process shouldn't get destroyed while we're "
            "holding a reference to it. Was the reference actually held?";
   } else {
-    // TODO(falken): Revert to DCHECK. Temporary check for debugging
-    // crbug.com/639193
     rph = RenderProcessHost::FromID(info->second.process_id);
-    CHECK(rph)
+    DCHECK(rph)
         << "Process " << info->second.process_id
         << " was destroyed unexpectedly. Did we actually hold a reference?";
   }
   rph->DecrementServiceWorkerRefCount();
   instance_info_.erase(info);
 }
 
 std::vector<int> ServiceWorkerProcessManager::SortProcessesForPattern(
     const GURL& pattern) const {
   PatternProcessRefMap::const_iterator it = pattern_processes_.find(pattern);
@@ skipping 44 matching lines @@
 namespace std {
 // Destroying ServiceWorkerProcessManagers only on the UI thread allows the
 // member WeakPtr to safely guard the object's lifetime when used on that
 // thread.
 void default_delete<content::ServiceWorkerProcessManager>::operator()(
     content::ServiceWorkerProcessManager* ptr) const {
   content::BrowserThread::DeleteSoon(
       content::BrowserThread::UI, FROM_HERE, ptr);
 }
 }  // namespace std