Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2320633002: Fix PushManager.subscribe() permission request on Android (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix PushManager.subscribe() permission request on Android https://codereview.chromium.org/2149883002 merged the PushMessagingPermissionContext into the NotificationPermissionContext. Unfortunately, this meant that PushManager.subscribe() tried to show a push messaging permission infobar instead of the notifications infobar, which fails because there is no push messaging infobar. This patch switches push messaging back to the notifications infobar. BUG=644256 Review-Url: https://codereview.chromium.org/2316673002 Cr-Commit-Position: refs/heads/master@{#416762} (cherry picked from commit e0db126dd99d297686d49eedd745d196708167ee) Committed: https://chromium.googlesource.com/chromium/src/+/d256ccde6cb75b87e4346d64e6e868028197ab6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java View 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_queue_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years, 3 months ago (2016-09-07 13:28:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d256ccde6cb75b87e4346d64e6e868028197ab6b.

Powered by Google App Engine
This is Rietveld 408576698