chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc - Issue 2320623003: Move title creation logic to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

Issue 2320623003: Move title creation logic to native (Closed)

Patch Set: don't trigger creation inside of GetTitleLayer Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

diff --git a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

index 913bd3142133268f799c7a968ed64f5722301c44..9ac66553c8583ff93d7c65b38349557cb6110837 100644

--- a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

+++ b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

@@ -150,6 +150,8 @@ void TabListSceneLayer::PutTabLayer(

own_tree_->AddChild(layer->layer());

visible_tabs_this_frame_.insert(id);

+ layer_title_cache_->BuildTitleLayer(id);

David Trainor- moved to gerrit 2016/09/09 05:29:09 If this doesn't live in LayerTitleCache won't this

mdjones 2016/09/09 15:40:13 Yep, forgot about tablet. Fixed.

DCHECK(layer);

if (layer) {

layer->SetProperties(

« chrome/browser/android/compositor/layer_title_cache.cc ('K') | « chrome/browser/android/compositor/layer_title_cache.cc ('k') | no next file » | no next file with comments »