Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4339)

Unified Diff: chrome/browser/android/compositor/layer_title_cache.cc

Issue 2320623003: Move title creation logic to native (Closed)
Patch Set: don't trigger creation inside of GetTitleLayer Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/layer_title_cache.cc
diff --git a/chrome/browser/android/compositor/layer_title_cache.cc b/chrome/browser/android/compositor/layer_title_cache.cc
index 1cd7755e9f3747a70dac2bced95bc7551e10259b..86ff62e03bb00abdc59a0a0dd69cca2bf0f48670 100644
--- a/chrome/browser/android/compositor/layer_title_cache.cc
+++ b/chrome/browser/android/compositor/layer_title_cache.cc
@@ -102,6 +102,15 @@ DecorationTitle* LayerTitleCache::GetTitleLayer(int tab_id) {
return layer_cache_.Lookup(tab_id);
}
+void LayerTitleCache::BuildTitleLayer(int tab_id) {
David Trainor- moved to gerrit 2016/09/09 05:29:09 Should this logic just live in GetTitleLayer?
mdjones 2016/09/09 15:40:13 Done.
+ if (layer_cache_.Lookup(tab_id))
+ return;
+
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_LayerTitleCache_buildUpdatedTitle(env, weak_java_title_cache_.get(env),
+ tab_id);
+}
+
void LayerTitleCache::SetResourceManager(
ui::ResourceManager* resource_manager) {
resource_manager_ = resource_manager;

Powered by Google App Engine
This is Rietveld 408576698