Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3257)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java

Issue 2320623003: Move title creation logic to native (Closed)
Patch Set: don't trigger creation inside of GetTitleLayer Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java
index d7dcf8fba19bcdfba874654fa328bf8ed2aade3c..f6c3bf65304e9d454c3abdadc0ffc1a686c4c3fe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocumentTabSwitcher.java
@@ -109,17 +109,8 @@ public class LayoutManagerDocumentTabSwitcher
@Override
public void initLayoutTabFromHost(final int tabId) {
- if (getTabModelSelector() == null || getActiveLayout() == null) return;
-
- TabModelSelector selector = ChromeApplication.getDocumentTabModelSelector();
- Tab tab = selector.getTabById(tabId);
- if (tab == null) return;
-
- LayoutTab layoutTab = getExistingLayoutTab(tabId);
- if (layoutTab == null) return;
-
- if (mTitleCache != null && layoutTab.isTitleNeeded()) {
- mTitleCache.getUpdatedTitle(tab, "");
+ if (mTitleCache != null) {
+ mTitleCache.remove(tabId);
}
super.initLayoutTabFromHost(tabId);
}
@@ -276,4 +267,4 @@ public class LayoutManagerDocumentTabSwitcher
}
}
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698