Move title creation logic to native

Move title creation logic to native

This change moves title generation logic to native. This allows titles
to be created as they are needed rather than all at once. The textures
for the title layers are still created by java since they start as
Android views, but this is now triggered by native code.

BUG=644770
Committed: https://crrev.com/00a508c5af4957e8986af18e71174352bc212e34
Cr-Commit-Position: refs/heads/master@{#417703}

[mdjones, 2016-09-07 18:10:39]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-09-07 18:10:39]

This can still be improved by removing titles that are not visible from the
cache similar to https://codereview.chromium.org/2293573002/. I think that can
be done in a follow-up though. PTAL

[mdjones, 2016-09-07 18:29:30]

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:95:
t.getTitleLayerNeedsUpdate());
I suppose I could also just trigger title creation here and avoid jni.

[David Trainor- moved to gerrit, 2016-09-08 20:47:46]

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
(right):

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java:234:
mTitleLayerNeedsUpdate = mIsTitleNeeded;
Would it makes sense to nuke the title from the cache when it changes?  Then
drive it off of requests to LayerTitleCache::GetTitleLayer()?  That way you're
not doing state tracking and management here.

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:95:
t.getTitleLayerNeedsUpdate());
On 2016/09/07 18:29:30, mdjones wrote:
> I suppose I could also just trigger title creation here and avoid jni.

Had a suggestion earlier along these lines

[mdjones, 2016-09-09 01:15:47]

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
(right):

https://codereview.chromium.org/2320623003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java:234:
mTitleLayerNeedsUpdate = mIsTitleNeeded;
On 2016/09/08 20:47:45, David Trainor wrote:
> Would it makes sense to nuke the title from the cache when it changes?  Then
> drive it off of requests to LayerTitleCache::GetTitleLayer()?  That way you're
> not doing state tracking and management here.

Done.

[David Trainor- moved to gerrit, 2016-09-09 05:29:09]

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
File chrome/browser/android/compositor/layer_title_cache.cc (right):

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
chrome/browser/android/compositor/layer_title_cache.cc:105: void
LayerTitleCache::BuildTitleLayer(int tab_id) {
Should this logic just live in GetTitleLayer?

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
File chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc
(right):

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc:153:
layer_title_cache_->BuildTitleLayer(id);
If this doesn't live in LayerTitleCache won't this break tablets?

[mdjones, 2016-09-09 15:40:13]

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
File chrome/browser/android/compositor/layer_title_cache.cc (right):

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
chrome/browser/android/compositor/layer_title_cache.cc:105: void
LayerTitleCache::BuildTitleLayer(int tab_id) {
On 2016/09/09 05:29:09, David Trainor wrote:
> Should this logic just live in GetTitleLayer?

Done.

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
File chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc
(right):

https://codereview.chromium.org/2320623003/diff/80001/chrome/browser/android/...
chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc:153:
layer_title_cache_->BuildTitleLayer(id);
On 2016/09/09 05:29:09, David Trainor wrote:
> If this doesn't live in LayerTitleCache won't this break tablets?

Yep, forgot about tablet. Fixed.

[David Trainor- moved to gerrit, 2016-09-09 18:33:40]

lgtm

[mdjones, 2016-09-09 20:07:19]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 20:57:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-09 21:01:30]

Description was changed from

==========
Move title creation logic to native

This change moves title generation logic to native. This allows titles
to be created as they are needed rather than all at once. The textures
for the title layers are still created by java since they start as
Android views, but this is now triggered by native code.

BUG=644770
==========

to

==========
Move title creation logic to native

This change moves title generation logic to native. This allows titles
to be created as they are needed rather than all at once. The textures
for the title layers are still created by java since they start as
Android views, but this is now triggered by native code.

BUG=644770

Committed: https://crrev.com/00a508c5af4957e8986af18e71174352bc212e34
Cr-Commit-Position: refs/heads/master@{#417703}
==========

[commit-bot: I haz the power, 2016-09-09 21:01:31]

Patchset 6 (id:??) landed as
https://crrev.com/00a508c5af4957e8986af18e71174352bc212e34
Cr-Commit-Position: refs/heads/master@{#417703}