Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5405)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java

Issue 2320623003: Move title creation logic to native (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
index 5a7fc237baec1a08bd8f6407f7669a0ef148f8c1..7f3f5236bf9459353876c376608302d00a2f0f45 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
@@ -18,6 +18,7 @@ import org.chromium.chrome.browser.favicon.FaviconHelper;
import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.ui.base.DeviceFormFactor;
import org.chromium.ui.resources.ResourceManager;
@@ -33,6 +34,8 @@ public class LayerTitleCache implements TitleCache {
private static int sNextResourceId = 1;
private final Context mContext;
+ private TabModelSelector mTabModelSelector;
+
private final SparseArray<Title> mTitles = new SparseArray<Title>();
private final int mFaviconSize;
@@ -83,11 +86,25 @@ public class LayerTitleCache implements TitleCache {
mNativeLayerTitleCache = 0;
}
+ public void setTabModelSelector(TabModelSelector tabModelSelector) {
+ mTabModelSelector = tabModelSelector;
+ }
+
@CalledByNative
private long getNativePtr() {
return mNativeLayerTitleCache;
}
+ @CalledByNative
+ private void buildUpdatedTitle(int tabId) {
+ if (mTabModelSelector == null) return;
+
+ Tab tab = mTabModelSelector.getTabById(tabId);
+ if (tab == null) return;
+
+ getUpdatedTitle(tab, "");
+ }
+
@Override
public String getUpdatedTitle(Tab tab, String defaultTitle) {
// If content view core is null, tab does not have direct access to the favicon, and we

Powered by Google App Engine
This is Rietveld 408576698