Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2320583003: Ensure we check root has focus when a text changed event fires. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a30d9c9ee24e8cd8edaeb724c0b2e80d91232bec Cr-Commit-Position: refs/heads/master@{#418320}

Patch Set 1 #

Patch Set 2 : Fix test. #

Patch Set 3 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
David Tseng
4 years, 3 months ago (2016-09-07 22:21:02 UTC) #4
dmazzoni
lgtm, but we probably want to do this for more event types, right?
4 years, 3 months ago (2016-09-07 22:31:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320583003/1
4 years, 3 months ago (2016-09-08 01:31:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/231993)
4 years, 3 months ago (2016-09-08 02:33:49 UTC) #9
David Tseng
lgtm, but we probably want to do this for more event types, right? I would ...
4 years, 3 months ago (2016-09-09 22:24:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320583003/40001
4 years, 3 months ago (2016-09-12 21:15:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2599)
4 years, 3 months ago (2016-09-12 21:25:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320583003/40001
4 years, 3 months ago (2016-09-13 18:39:22 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 18:55:27 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 18:57:21 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a30d9c9ee24e8cd8edaeb724c0b2e80d91232bec
Cr-Commit-Position: refs/heads/master@{#418320}

Powered by Google App Engine
This is Rietveld 408576698