|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by David Tseng Modified:
4 years, 3 months ago Reviewers:
dmazzoni CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure we check root has focus when a text changed event fires.
Text changed continues to fire in a background tab in a Hangouts session.
This causes ChromeVox to attempt to set-up an editable text handler.
The node itself has focused state, but the root (correctly) does not.
Use this as a signal to ignore the event.
We need to further qualify this to allow text changes from non-web rooted trees
because the omni bar fires text changes (without focus events) when we open a new tab.
TEST=manual
BUG=641733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/a30d9c9ee24e8cd8edaeb724c0b2e80d91232bec
Cr-Commit-Position: refs/heads/master@{#418320}
Patch Set 1 #Patch Set 2 : Fix test. #Patch Set 3 : Fix tests. #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG= ========== to ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm, but we probably want to do this for more event types, right?
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm, but we probably want to do this for more event types, right? I would prefer ax never fires these events on backgrounded tabs; maybe something to do this for all platforms (e.g. an internal event that's used only to update the tree, but never delivered to the client). AXEventFilter or something.
The CQ bit was checked by dtseng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2320583003/#ps40001 (title: "Fix tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Ensure we check root has focus when a text changed event fires. Text changed continues to fire in a background tab in a Hangouts session. This causes ChromeVox to attempt to set-up an editable text handler. The node itself has focused state, but the root (correctly) does not. Use this as a signal to ignore the event. We need to further qualify this to allow text changes from non-web rooted trees because the omni bar fires text changes (without focus events) when we open a new tab. TEST=manual BUG=641733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a30d9c9ee24e8cd8edaeb724c0b2e80d91232bec Cr-Commit-Position: refs/heads/master@{#418320} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a30d9c9ee24e8cd8edaeb724c0b2e80d91232bec Cr-Commit-Position: refs/heads/master@{#418320} |
