Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 2320583003: Ensure we check root has focus when a text changed event fires. (Closed)
Patch Set: Fix tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
index 4c3e3d42c0f0ba27e40f7fc29a75fa8364a1fe45..055a0322761f80f90a4577bc68eba54a79658bb4 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
@@ -32,6 +32,7 @@ DesktopAutomationHandler = function(node) {
/**
* The object that speaks changes to an editable text field.
* @type {editing.TextEditHandler}
+ * @private
*/
this.textEditHandler_ = null;
@@ -322,7 +323,10 @@ DesktopAutomationHandler.prototype = {
ChromeVoxState.instance.mode === ChromeVoxMode.CLASSIC)
return;
- if (!evt.target.state.focused)
+ if (!evt.target.state.focused ||
+ (evt.target.root.role != RoleType.desktop &&
+ evt.target.root.parent &&
+ !evt.target.root.parent.state.focused))
return;
if (!ChromeVoxState.instance.currentRange) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698