Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2320583002: Introduce OpenWorld. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, Harry Terkelsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -66 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 7 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 7 chunks +39 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 4 chunks +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/subtypeset_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Johnni Winther
4 years, 3 months ago (2016-09-07 11:23:49 UTC) #2
Johnni Winther
ping
4 years, 3 months ago (2016-09-19 13:28:08 UTC) #3
Johnni Winther
4 years, 3 months ago (2016-09-19 13:31:23 UTC) #4
Harry Terkelsen
lgtm https://codereview.chromium.org/2320583002/diff/1/pkg/compiler/lib/src/types/flat_type_mask.dart File pkg/compiler/lib/src/types/flat_type_mask.dart (right): https://codereview.chromium.org/2320583002/diff/1/pkg/compiler/lib/src/types/flat_type_mask.dart#newcode51 pkg/compiler/lib/src/types/flat_type_mask.dart:51: factory FlatTypeMask.normalized(ClassElement base, int flags, ClassWorld world) { ...
4 years, 3 months ago (2016-09-19 20:41:11 UTC) #6
Johnni Winther
https://codereview.chromium.org/2320583002/diff/1/pkg/compiler/lib/src/types/flat_type_mask.dart File pkg/compiler/lib/src/types/flat_type_mask.dart (right): https://codereview.chromium.org/2320583002/diff/1/pkg/compiler/lib/src/types/flat_type_mask.dart#newcode51 pkg/compiler/lib/src/types/flat_type_mask.dart:51: factory FlatTypeMask.normalized(ClassElement base, int flags, ClassWorld world) { On ...
4 years, 3 months ago (2016-09-21 09:44:59 UTC) #7
Johnni Winther
4 years, 3 months ago (2016-09-21 09:48:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ca3c2882ae96f4ec41f2253771cbcd6b7eac24fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698