Introduce OpenWorld.

pkg/compiler/lib/src/universe/selector.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.selector;
 
 import '../common.dart';
 import '../common/names.dart' show Names;
 import '../elements/elements.dart'
     show
         Element,
         Elements,
         FunctionElement,
         FunctionSignature,
         Name,
         LibraryElement,
         PublicName;
 import '../util/util.dart' show Hashing;
-import '../world.dart' show World;
+import '../common/resolution.dart' show Target;
 import 'call_structure.dart' show CallStructure;
 
 class SelectorKind {
   final String name;
   final int hashCode;
   const SelectorKind(this.name, this.hashCode);
 
   static const SelectorKind GETTER = const SelectorKind('getter', 0);
   static const SelectorKind SETTER = const SelectorKind('setter', 1);
   static const SelectorKind CALL = const SelectorKind('call', 2);
@@ skipping 180 matching lines @@
     const int SETTER = 2;
     int kind = METHOD;
     if (isGetter) {
       kind = GETTER;
     } else if (isSetter) {
       kind = SETTER;
     }
     return kind;
   }
 
-  bool appliesUnnamed(Element element, World world) {
-    assert(sameNameHack(element, world));
-    return appliesUntyped(element, world);
+  bool appliesUnnamed(Element element, Target target) {
+    assert(sameNameHack(element, target));
+    return appliesUntyped(element, target);
   }
 
-  bool appliesUntyped(Element element, World world) {
-    assert(sameNameHack(element, world));
+  bool appliesUntyped(Element element, Target target) {
+    assert(sameNameHack(element, target));
     if (Elements.isUnresolved(element)) return false;
     if (memberName.isPrivate && memberName.library != element.library) {
       // TODO(johnniwinther): Maybe this should be
       // `memberName != element.memberName`.
       return false;
     }
-    if (world.isForeign(element)) return true;
+    if (target.isForeign(element)) return true;
     if (element.isSetter) return isSetter;
     if (element.isGetter) return isGetter || isCall;
     if (element.isField) {
       return isSetter
           ? !element.isFinal && !element.isConst
           : isGetter || isCall;
     }
     if (isGetter) return true;
     if (isSetter) return false;
     return signatureApplies(element);
   }
 
   bool signatureApplies(FunctionElement function) {
     if (Elements.isUnresolved(function)) return false;
     return callStructure.signatureApplies(function.functionSignature);
   }
 
-  bool sameNameHack(Element element, World world) {
+  bool sameNameHack(Element element, Target target) {

[Harry Terkelsen, 2016/09/19 20:41:11]

the Target argument is unused, remove?

[Johnni Winther, 2016/09/21 09:44:59]

Done.

     // TODO(ngeoffray): Remove workaround checks.
     return element.isConstructor || name == element.name;
   }
 
-  bool applies(Element element, World world) {
-    if (!sameNameHack(element, world)) return false;
-    return appliesUnnamed(element, world);
+  bool applies(Element element, Target target) {
+    if (!sameNameHack(element, target)) return false;
+    return appliesUnnamed(element, target);
   }
 
   bool match(SelectorKind kind, Name memberName, CallStructure callStructure) {
     return this.kind == kind &&
         this.memberName == memberName &&
         this.callStructure.match(callStructure);
   }
 
   static int computeHashCode(
       SelectorKind kind, Name name, CallStructure callStructure) {
     // Add bits from name and kind.
     int hash = Hashing.mixHashCodeBits(name.hashCode, kind.hashCode);
     // Add bits from the call structure.
     return Hashing.mixHashCodeBits(hash, callStructure.hashCode);
   }
 
   String toString() {
     return 'Selector($kind, $name, ${callStructure.structureToString()})';
   }
 
   Selector toCallSelector() => new Selector.callClosureFrom(this);
 }