Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 23205010: Create trychange_git.py, for starting tryjobs in a pure-git world. (Closed)

Created:
7 years, 4 months ago by agable
Modified:
4 years, 6 months ago
Reviewers:
cmp, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Create trychange_git.py, for starting tryjobs in a pure-git world. This is a companion CL to https://codereview.chromium.org/23112007/ This file takes your local feature branch, pushes it to a special try-ref in a remote repo, and then posts a json blob to an appengine app that a buildbot tryserver will be polling from. I'd like to integrate it into git_cl.py, but I haven't figured out the best way to determine if a user wants to issue a tryjob this way or the normal way via rietveld.

Patch Set 1 #

Patch Set 2 : Better build properties. #

Total comments: 4

Patch Set 3 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
A trychange_git.py View 1 2 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agable
7 years, 4 months ago (2013-08-16 23:55:39 UTC) #1
cmp
lgtm with comment and nit But this should probably not be in depot_tools for now. ...
7 years, 4 months ago (2013-08-20 05:52:29 UTC) #2
agable
Okay, when the appengine app review is done and we decide where to land that ...
7 years, 4 months ago (2013-08-20 07:48:08 UTC) #3
agable
On 2013/08/20 07:48:08, Aaron Gable wrote: > Okay, when the appengine app review is done ...
7 years, 4 months ago (2013-08-21 13:02:14 UTC) #4
cmp
7 years, 4 months ago (2013-08-22 04:06:45 UTC) #5
Message was sent while issue was closed.
I agree about changing the name from tryserver to something else for the same
reason.  That SGTM.

Powered by Google App Engine
This is Rietveld 408576698