Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2320473003: [turbofan] Typer changes to avoid Type representation dimension (Closed)
Patch Set: A few more changes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index f1b82fa767d916e954c953bb18ca7cb8e883da51..4c80fc6d438428ed38ee59a429bcf1f08891d587 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -979,8 +979,8 @@ Reduction JSTypedLowering::ReduceJSToObject(Node* node) {
node->ReplaceInput(1, rfalse);
node->ReplaceInput(2, control);
node->TrimInputCount(3);
- NodeProperties::ChangeOp(node,
- common()->Phi(MachineRepresentation::kTagged, 2));
+ NodeProperties::ChangeOp(
mvstanton 2016/09/13 13:03:54 per current contract, this would be ignored.
+ node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
return Changed(node);
}
@@ -1186,8 +1186,9 @@ Reduction JSTypedLowering::ReduceJSInstanceOf(Node* node) {
Node* loop = control = graph()->NewNode(common()->Loop(2), control, control);
Node* eloop = effect =
graph()->NewNode(common()->EffectPhi(2), effect, effect, loop);
- Node* vloop = object = graph()->NewNode(
- common()->Phi(MachineRepresentation::kTagged, 2), object, object, loop);
+ Node* vloop = object =
+ graph()->NewNode(common()->Phi(MachineRepresentation::kTaggedPointer, 2),
+ object, object, loop);
// TODO(jarin): This is a very ugly hack to work-around the super-smart
// implicit typing of the Phi, which goes completely nuts if the {object}
// is for example a HeapConstant.
@@ -1284,8 +1285,8 @@ Reduction JSTypedLowering::ReduceJSInstanceOf(Node* node) {
node->ReplaceInput(4, vfalse1);
node->ReplaceInput(5, control);
node->TrimInputCount(6);
- NodeProperties::ChangeOp(node,
- common()->Phi(MachineRepresentation::kTagged, 5));
+ NodeProperties::ChangeOp(
+ node, common()->Phi(MachineRepresentation::kTaggedPointer, 5));
return Changed(node);
}
@@ -1402,8 +1403,8 @@ Reduction JSTypedLowering::ReduceJSConvertReceiver(Node* node) {
node->ReplaceInput(1, rfalse);
node->ReplaceInput(2, control);
node->TrimInputCount(3);
- NodeProperties::ChangeOp(node,
- common()->Phi(MachineRepresentation::kTagged, 2));
+ NodeProperties::ChangeOp(
+ node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
return Changed(node);
}
@@ -1823,8 +1824,8 @@ Reduction JSTypedLowering::ReduceJSForInNext(Node* node) {
node->ReplaceInput(1, vfalse0);
node->ReplaceInput(2, control);
node->TrimInputCount(3);
- NodeProperties::ChangeOp(node,
- common()->Phi(MachineRepresentation::kTagged, 2));
+ NodeProperties::ChangeOp(
+ node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
return Changed(node);
}

Powered by Google App Engine
This is Rietveld 408576698