[turbofan] Typer changes to avoid Type representation dimension

src/compiler/js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-typed-lowering.h"
 
 #include "src/builtins/builtins-utils.h"
 #include "src/code-factory.h"
 #include "src/compilation-dependencies.h"
 #include "src/compiler/access-builder.h"
@@ skipping 961 matching lines @@
 
   control = graph()->NewNode(common()->Merge(2), if_true, if_false);
   effect = graph()->NewNode(common()->EffectPhi(2), etrue, efalse, control);
 
   // Morph the {node} into an appropriate Phi.
   ReplaceWithValue(node, node, effect, control);
   node->ReplaceInput(0, rtrue);
   node->ReplaceInput(1, rfalse);
   node->ReplaceInput(2, control);
   node->TrimInputCount(3);
-  NodeProperties::ChangeOp(node,
-                           common()->Phi(MachineRepresentation::kTagged, 2));
+  NodeProperties::ChangeOp(

[mvstanton, 2016/09/13 13:03:54]

per current contract, this would be ignored.

+      node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
   return Changed(node);
 }
 
 Reduction JSTypedLowering::ReduceJSLoadNamed(Node* node) {
   DCHECK_EQ(IrOpcode::kJSLoadNamed, node->opcode());
   Node* receiver = NodeProperties::GetValueInput(node, 0);
   Type* receiver_type = NodeProperties::GetType(receiver);
   Node* effect = NodeProperties::GetEffectInput(node);
   Node* control = NodeProperties::GetControlInput(node);
   Handle<Name> name = NamedAccessOf(node->op()).name();
@@ skipping 185 matching lines @@
   Node* if_true0 = graph()->NewNode(common()->IfTrue(), branch0);
   Node* etrue0 = effect;
   Node* vtrue0 = jsgraph()->FalseConstant();
 
   control = graph()->NewNode(common()->IfFalse(), branch0);
 
   // Loop through the {object}s prototype chain looking for the {prototype}.
   Node* loop = control = graph()->NewNode(common()->Loop(2), control, control);
   Node* eloop = effect =
       graph()->NewNode(common()->EffectPhi(2), effect, effect, loop);
-  Node* vloop = object = graph()->NewNode(
-      common()->Phi(MachineRepresentation::kTagged, 2), object, object, loop);
+  Node* vloop = object =
+      graph()->NewNode(common()->Phi(MachineRepresentation::kTaggedPointer, 2),
+                       object, object, loop);
   // TODO(jarin): This is a very ugly hack to work-around the super-smart
   // implicit typing of the Phi, which goes completely nuts if the {object}
   // is for example a HeapConstant.
   NodeProperties::SetType(vloop, Type::NonInternal());
 
   // Load the {object} map and instance type.
   Node* object_map = effect =
       graph()->NewNode(simplified()->LoadField(AccessBuilder::ForMap()), object,
                        effect, control);
   Node* object_instance_type = effect = graph()->NewNode(
@@ skipping 76 matching lines @@
 
   // Morph the {node} into an appropriate Phi.
   ReplaceWithValue(node, node, effect, control);
   node->ReplaceInput(0, vtrue0);
   node->ReplaceInput(1, vtrue1);
   node->ReplaceInput(2, vtrue2);
   node->ReplaceInput(3, vtrue3);
   node->ReplaceInput(4, vfalse1);
   node->ReplaceInput(5, control);
   node->TrimInputCount(6);
-  NodeProperties::ChangeOp(node,
-                           common()->Phi(MachineRepresentation::kTagged, 5));
+  NodeProperties::ChangeOp(
+      node, common()->Phi(MachineRepresentation::kTaggedPointer, 5));
   return Changed(node);
 }
 
 Reduction JSTypedLowering::ReduceJSLoadContext(Node* node) {
   DCHECK_EQ(IrOpcode::kJSLoadContext, node->opcode());
   ContextAccess const& access = ContextAccessOf(node->op());
   Node* effect = NodeProperties::GetEffectInput(node);
   Node* control = graph()->start();
   for (size_t i = 0; i < access.depth(); ++i) {
     Node* previous = effect = graph()->NewNode(
@@ skipping 96 matching lines @@
 
     control = graph()->NewNode(common()->Merge(2), if_true, if_false);
     effect = graph()->NewNode(common()->EffectPhi(2), etrue, efalse, control);
 
     // Morph the {node} into an appropriate Phi.
     ReplaceWithValue(node, node, effect, control);
     node->ReplaceInput(0, rtrue);
     node->ReplaceInput(1, rfalse);
     node->ReplaceInput(2, control);
     node->TrimInputCount(3);
-    NodeProperties::ChangeOp(node,
-                             common()->Phi(MachineRepresentation::kTagged, 2));
+    NodeProperties::ChangeOp(
+        node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
     return Changed(node);
   }
 
   // Check if {receiver} is already a JSReceiver.
   Node* check0 = graph()->NewNode(simplified()->ObjectIsReceiver(), receiver);
   Node* branch0 =
       graph()->NewNode(common()->Branch(BranchHint::kTrue), check0, control);
   Node* if_true0 = graph()->NewNode(common()->IfTrue(), branch0);
   Node* if_false0 = graph()->NewNode(common()->IfFalse(), branch0);
 
@@ skipping 399 matching lines @@
     if_false0 = graph()->NewNode(common()->IfSuccess(), vfalse0);
   }
 
   control = graph()->NewNode(common()->Merge(2), if_true0, if_false0);
   effect = graph()->NewNode(common()->EffectPhi(2), etrue0, efalse0, control);
   ReplaceWithValue(node, node, effect, control);
   node->ReplaceInput(0, vtrue0);
   node->ReplaceInput(1, vfalse0);
   node->ReplaceInput(2, control);
   node->TrimInputCount(3);
-  NodeProperties::ChangeOp(node,
-                           common()->Phi(MachineRepresentation::kTagged, 2));
+  NodeProperties::ChangeOp(
+      node, common()->Phi(MachineRepresentation::kTaggedPointer, 2));
   return Changed(node);
 }
 
 Reduction JSTypedLowering::ReduceJSGeneratorStore(Node* node) {
   DCHECK_EQ(IrOpcode::kJSGeneratorStore, node->opcode());
   Node* generator = NodeProperties::GetValueInput(node, 0);
   Node* continuation = NodeProperties::GetValueInput(node, 1);
   Node* offset = NodeProperties::GetValueInput(node, 2);
   Node* context = NodeProperties::GetContextInput(node);
   Node* effect = NodeProperties::GetEffectInput(node);
@@ skipping 168 matching lines @@
 }
 
 
 CompilationDependencies* JSTypedLowering::dependencies() const {
   return dependencies_;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8