[turbofan] Typer changes to avoid Type representation dimension

[turbofan] Typer changes to avoid Type representation dimension

This CL "weakens" the typer somewhat, as it was querying aspects of
Type that are within the representation dimension. It's not the right
place to do that.

BUG=

Committed: https://crrev.com/c8e93b0613615b8622713db8560ae8c20f12d270
Cr-Commit-Position: refs/heads/master@{#39391}

[mvstanton, 2016-09-08 12:24:25]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 12:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 12:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 12:36:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2016-09-13 13:03:05]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 13:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-09-13 13:03:51]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2016-09-13 13:03:54]

Hi Benedikt, here are the representation changes we discussed last week. thx!
--Mike

https://codereview.chromium.org/2320473003/diff/20001/src/compiler/js-create-...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2320473003/diff/20001/src/compiler/js-create-...
src/compiler/js-create-lowering.cc:621:
common()->Phi(MachineRepresentation::kTaggedPointer, 2), call_holey,
don't bother it is ignored, "current contract" is tagged.

https://codereview.chromium.org/2320473003/diff/20001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/2320473003/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:982: NodeProperties::ChangeOp(
per current contract, this would be ignored.

[commit-bot: I haz the power, 2016-09-13 13:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:51:58]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-09-13 17:02:29]

LGTM once comment addressed.

https://codereview.chromium.org/2320473003/diff/60001/src/compiler/access-bui...
File src/compiler/access-builder.cc (right):

https://codereview.chromium.org/2320473003/diff/60001/src/compiler/access-bui...
src/compiler/access-builder.cc:349: MachineType::TaggedPointer(),
This can actually contain a Smi (yeah it's this weird TypedArray hackery...), so
it has to remain MachineType::AnyTagged()

[mvstanton, 2016-09-13 18:33:51]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-09-13 18:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2320473003/#ps80001
(title: "quick fix.")

[commit-bot: I haz the power, 2016-09-13 18:34:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-09-13 18:34:14]

right on, addressed, thx :)

https://codereview.chromium.org/2320473003/diff/60001/src/compiler/access-bui...
File src/compiler/access-builder.cc (right):

https://codereview.chromium.org/2320473003/diff/60001/src/compiler/access-bui...
src/compiler/access-builder.cc:349: MachineType::TaggedPointer(),
On 2016/09/13 17:02:28, Benedikt Meurer wrote:
> This can actually contain a Smi (yeah it's this weird TypedArray hackery...),
so
> it has to remain MachineType::AnyTagged()

Done.

[commit-bot: I haz the power, 2016-09-13 18:58:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-13 18:59:18]

Description was changed from

==========
[turbofan] Typer changes to avoid Type representation dimension

This CL "weakens" the typer somewhat, as it was querying aspects of
Type that are within the representation dimension. It's not the right
place to do that.

BUG=
==========

to

==========
[turbofan] Typer changes to avoid Type representation dimension

This CL "weakens" the typer somewhat, as it was querying aspects of
Type that are within the representation dimension. It's not the right
place to do that.

BUG=

Committed: https://crrev.com/c8e93b0613615b8622713db8560ae8c20f12d270
Cr-Commit-Position: refs/heads/master@{#39391}
==========

[commit-bot: I haz the power, 2016-09-13 18:59:19]

Patchset 5 (id:??) landed as
https://crrev.com/c8e93b0613615b8622713db8560ae8c20f12d270
Cr-Commit-Position: refs/heads/master@{#39391}