Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 2320453002: arc: Fix thread unsafe behavior of ArcDownloadsWatcherService (Closed)

Created:
4 years, 3 months ago by hashimoto
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Fix thread unsafe behavior of ArcDownloadsWatcherService ArcBridgeService is not thread-safe. WeakPtr should be defererenced only on the thread to which the factory belongs. BUG=643059 Review-Url: https://codereview.chromium.org/2304523002 Cr-Commit-Position: refs/heads/master@{#416194} (cherry picked from commit 3c74f1cb2742e9b050fbc830f1ac0e06163c2370) Committed: https://chromium.googlesource.com/chromium/src/+/5bb81307776aa149e9fbbce05e77bd30fb058e4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/chromeos/arc/arc_downloads_watcher_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hashimoto
4 years, 3 months ago (2016-09-07 04:46:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bb81307776aa149e9fbbce05e77bd30fb058e4d (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698