Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

Issue 2320453002: arc: Fix thread unsafe behavior of ArcDownloadsWatcherService (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_downloads_watcher_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc b/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc
index 8bae833b113d0fc53cc32e5984c8812d47347b3b..c550601981af4ff434b52e4fef760e2e75abf836 100644
--- a/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc
+++ b/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc
@@ -76,8 +76,7 @@ std::vector<base::FilePath> CollectChangedPaths(
// Downloads directory.
class ArcDownloadsWatcherService::DownloadsWatcher {
public:
- using Callback =
- base::Callback<void(const std::vector<base::FilePath>& paths)>;
+ using Callback = base::Callback<void(mojo::Array<mojo::String> paths)>;
explicit DownloadsWatcher(const Callback& callback);
~DownloadsWatcher();
@@ -147,7 +146,13 @@ void ArcDownloadsWatcherService::DownloadsWatcher::OnFilePathChanged(
last_timestamp_map_ = std::move(current_timestamp_map);
- callback_.Run(changed_paths);
+ mojo::Array<mojo::String> mojo_paths(changed_paths.size());
+ for (size_t i = 0; i < changed_paths.size(); ++i) {
+ mojo_paths[i] = changed_paths[i].value();
+ }
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(callback_, base::Passed(std::move(mojo_paths))));
}
TimestampMap ArcDownloadsWatcherService::DownloadsWatcher::BuildTimestampMap()
@@ -217,19 +222,14 @@ void ArcDownloadsWatcherService::StopWatchingDownloads() {
}
void ArcDownloadsWatcherService::OnDownloadsChanged(
- const std::vector<base::FilePath>& paths) {
- DCHECK_CURRENTLY_ON(BrowserThread::FILE);
+ mojo::Array<mojo::String> paths) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
auto instance = arc_bridge_service()->file_system()->instance();
if (!instance) {
return;
}
-
- mojo::Array<mojo::String> mojo_paths(paths.size());
- for (size_t i = 0; i < paths.size(); ++i) {
- mojo_paths[i] = paths[i].value();
- }
- instance->RequestMediaScan(std::move(mojo_paths));
+ instance->RequestMediaScan(std::move(paths));
}
} // namespace arc
« no previous file with comments | « chrome/browser/chromeos/arc/arc_downloads_watcher_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698