Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2320333002: Fixes build breakage (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes build breakage https://codereview.chromium.org/2318223003 landed just before my change to remove ash.gyp, so no conflict and build broke. I've updated the build files appropriately. TBR=msw@chromium.rog BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/a824a41b08726dca1cba80f8f4e5f5cdd6a00dd8 Cr-Commit-Position: refs/heads/master@{#417447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ash/BUILD.gn View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sky
4 years, 3 months ago (2016-09-09 00:14:15 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a824a41b08726dca1cba80f8f4e5f5cdd6a00dd8 Cr-Commit-Position: refs/heads/master@{#417447}
4 years, 3 months ago (2016-09-09 00:20:15 UTC) #4
msw
4 years, 3 months ago (2016-09-09 00:29:45 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698