Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 232023002: Enable downloading archive only for Desktop builds (Closed)

Created:
6 years, 8 months ago by prasadv
Modified:
6 years, 8 months ago
Reviewers:
shatch, qyearsley
CC:
chromium-reviews
Visibility:
Public.

Description

Enable downloading archive only for Desktop builds. Added checks to download archives only for the desktop platforms. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263141

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/run-bisect-perf-regression.py View 1 2 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
prasadv
6 years, 8 months ago (2014-04-09 22:28:29 UTC) #1
qyearsley
LGTM https://codereview.chromium.org/232023002/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/232023002/diff/1/tools/bisect-perf-regression.py#newcode1513 tools/bisect-perf-regression.py:1513: return False I guess this could theoretically also ...
6 years, 8 months ago (2014-04-10 19:14:46 UTC) #2
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-10 23:50:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/232023002/1
6 years, 8 months ago (2014-04-10 23:51:01 UTC) #4
prasadv
The CQ bit was unchecked by prasadv@chromium.org
6 years, 8 months ago (2014-04-11 00:04:01 UTC) #5
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-11 00:11:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/232023002/10001
6 years, 8 months ago (2014-04-11 00:11:36 UTC) #7
commit-bot: I haz the power
Change committed as 263141
6 years, 8 months ago (2014-04-11 00:13:14 UTC) #8
Lei Zhang
6 years, 8 months ago (2014-04-11 00:21:00 UTC) #9
Message was sent while issue was closed.
Please properly fill out the commit message.

Reviewers: it's your job to make sure the above happens.

Powered by Google App Engine
This is Rietveld 408576698