Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 232023002: Enable downloading archive only for Desktop builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index f924a6e8c418650fa47bccd9e9149c3d972d71f8..e3cad8c4456ead7fb935522811caf7ce6242bba4 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -393,6 +393,22 @@ def _RunBisectionScript(config, working_directory, path_to_file, path_to_goma,
if path_to_extra_src:
cmd.extend(['--extra_src', path_to_extra_src])
+ # These flags are used to download build archives from cloud storage if
+ # available, otherwise will post a try_job_http request to build it on
+ # tryserver.
+ if config.get('gs_bucket'):
+ if config.get('builder_host') and config.get('builder_port'):
+ cmd.extend(['--gs_bucket', config['gs_bucket'],
+ '--builder_host', config['builder_host'],
+ '--builder_port', config['builder_port']
+ ])
+ else:
+ print ('Error: Specified gs_bucket, but missing builder_host or '
+ 'builder_port information in config.')
+ return 1
+
+ cmd.extend(['-r', config['repeat_count']])
+
if dry_run:
cmd.extend(['--debug_ignore_build', '--debug_ignore_sync',
'--debug_ignore_perf_test'])
@@ -443,7 +459,7 @@ def main():
(opts, args) = parser.parse_args()
path_to_current_directory = os.path.abspath(os.path.dirname(sys.argv[0]))
-
+ import pdb; pdb.set_trace()
# If they've specified their own config file, use that instead.
if opts.path_to_config:
path_to_bisect_cfg = opts.path_to_config
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698