Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2320223002: Revert of Track step nesting in StreamEngine. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py@emit-initial-properties
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of https://codereview.chromium.org/2245113002/ ) Reason for revert: Broke a build: https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/recipe-autoroller-internal/builds/18474/steps/build.roll/logs/candidate%20%233 Original issue's description: > Track step nesting in StreamEngine. > > Currently, step nesting is tracked by the step runner as an integer, > which is passed to the stream engine as the `set_nest_level` post-create > event. This poses two problems, namely: > - The nest level is known to the runner immediately on step creation, > but is presented to the stream engine as a separate piece of > information. > - This forces the step runner's concept of nesting (integer) onto the > stream engine, when all it really cares about is whether or not a step > is nested. > > This patch updates the API to pass the nested state as a boolean: either > a step is nested in the previous step, or it isn't. The stream engine is > responsible for tracking how it represents this to the stream's > consumer. The nested state is also passed at step creation, making > nesting an atomic step propety instead of an out-of-band option. > > Along the way, small cleanups. > > BUG=chromium:628770 > TEST=local > - Ran unit tests locally. > - `./recipes.py --package ./infra/config/recipes.cfg run example/nested` > > Committed: https://github.com/luci/recipes-py/commit/4b3ff6014bcb018aff9ae2755faf47cc304f47af TBR=martiniss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:628770 Committed: https://github.com/luci/recipes-py/commit/339eace18cba35868b8bbb039100448fbfc58d15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -358 lines) Patch
M recipe_engine/run.py View 5 chunks +10 lines, -12 lines 0 comments Download
M recipe_engine/simulation_test.py View 4 chunks +2 lines, -29 lines 0 comments Download
M recipe_engine/step_runner.py View 6 chunks +12 lines, -17 lines 0 comments Download
M recipe_engine/stream.py View 9 chunks +129 lines, -124 lines 0 comments Download
M recipe_engine/unittests/run_test.py View 2 chunks +1 line, -3 lines 0 comments Download
M recipe_engine/unittests/stream_test.py View 1 chunk +2 lines, -4 lines 0 comments Download
M recipe_modules/generator_script/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.py View 1 chunk +0 lines, -14 lines 0 comments Download
D recipe_modules/generator_script/example.expected/nested.json View 1 chunk +0 lines, -127 lines 0 comments Download
M recipe_modules/step/api.py View 2 chunks +8 lines, -19 lines 0 comments Download
M recipe_modules/step/config.py View 1 chunk +2 lines, -1 line 0 comments Download
M recipes.py View 1 chunk +2 lines, -3 lines 0 comments Download
M recipes/example/nested.py View 2 chunks +2 lines, -2 lines 0 comments Download
M recipes/example/nested.expected/basic.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dnj
Created Revert of Track step nesting in StreamEngine.
4 years, 3 months ago (2016-09-08 19:11:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320223002/1
4 years, 3 months ago (2016-09-08 19:12:02 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:12:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/339eace18cba35868b8bbb039100448fbfc...

Powered by Google App Engine
This is Rietveld 408576698