Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: recipe_engine/simulation_test.py

Issue 2320223002: Revert of Track step nesting in StreamEngine. (Closed) Base URL: https://github.com/luci/recipes-py@emit-initial-properties
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_engine/run.py ('k') | recipe_engine/step_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/simulation_test.py
diff --git a/recipe_engine/simulation_test.py b/recipe_engine/simulation_test.py
index 87c81ff8a0618d9e807033e40cd96390dd860bb3..81091a0a362f8a19f24cdd09110c20df6e2f3613 100644
--- a/recipe_engine/simulation_test.py
+++ b/recipe_engine/simulation_test.py
@@ -4,8 +4,6 @@
"""Provides simulator test coverage for individual recipes."""
-import StringIO
-import contextlib
import json
import logging
import os
@@ -13,7 +11,6 @@
import sys
from . import env
-from . import stream
import expect_tests
# This variable must be set in the dynamic scope of the functions in this file.
@@ -58,24 +55,6 @@
return expect_tests.Result(raw_expectations)
-class SimulationAnnotatorStreamEngine(stream.AnnotatorStreamEngine):
-
- def __init__(self):
- self._step_buffer_map = {}
- super(SimulationAnnotatorStreamEngine, self).__init__(
- self.step_buffer(None))
-
- def step_buffer(self, step_name):
- return self._step_buffer_map.setdefault(step_name, StringIO.StringIO())
-
- def _new_step_stream(self, step_name, allow_subannotations, nest_level):
- return self._create_step_stream(
- step_name,
- self.step_buffer(step_name),
- allow_subannotations,
- nest_level)
-
-
def RunRecipe(test_data):
"""Actually runs the recipe given the GenTests-supplied test_data."""
from . import config_types
@@ -85,14 +64,8 @@
from . import stream
config_types.ResetTostringFns()
-
- annotator = SimulationAnnotatorStreamEngine()
- stream_engine = stream.ProductStreamEngine(
- stream.StreamEngineInvariants(),
- annotator)
- with stream_engine:
- step_runner = step_runner.SimulationStepRunner(stream_engine, test_data,
- annotator)
+ with stream.StreamEngineInvariants() as stream_engine:
+ step_runner = step_runner.SimulationStepRunner(stream_engine, test_data)
engine = run.RecipeEngine(step_runner, test_data.properties, _UNIVERSE)
recipe_script = _UNIVERSE.load_recipe(test_data.properties['recipe'])
« no previous file with comments | « recipe_engine/run.py ('k') | recipe_engine/step_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698