Reland of Fix leaked internal font

Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

The previous revert was caused by memory management errors 
which were fixed at https://codereview.chromium.org/2322043002/

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/9a0736803ae6749ec508e1c3ff5f04a483bbcb56

[Wei Li, 2016-09-08 18:46:39]

Description was changed from

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a boolean parameter and pass it along
during the creation of the font.

BUG=pdfium:242
==========

to

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

BUG=pdfium:242
==========

[Wei Li, 2016-09-08 19:00:13]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:00:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:17:45]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-08 21:51:56]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-09-08 21:51:57]

This is a reland since the memory errors which caused ASAN failed were
addressed. Pls review, thanks.

[Lei Zhang, 2016-09-08 22:06:38]

lgtm, but can you reference the CL that fixed things?

[Wei Li, 2016-09-08 22:19:49]

Description was changed from

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

BUG=pdfium:242
==========

to

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

The previous revert was caused by memory management errors 
which were fixed at https://codereview.chromium.org/2322043002/

BUG=pdfium:242
==========

[Wei Li, 2016-09-08 22:20:30]

On 2016/09/08 22:06:38, Lei Zhang wrote:
> lgtm, but can you reference the CL that fixed things?

Updated the description to add the link

[Wei Li, 2016-09-08 22:21:00]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:21:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:21:26]

Description was changed from

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

The previous revert was caused by memory management errors 
which were fixed at https://codereview.chromium.org/2322043002/

BUG=pdfium:242
==========

to

==========
Reland of Fix leaked internal font

Reland of Fix leaked internal font (patchset #2 id:60001 of
https://codereview.chromium.org/2297303004/ )

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a new method to take the ownership
of the font and mark it as internal font properly.

The previous revert was caused by memory management errors 
which were fixed at https://codereview.chromium.org/2322043002/

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/9a0736803ae6749ec508e1c3ff5f04a483bb...
==========

[commit-bot: I haz the power, 2016-09-08 22:21:27]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9a0736803ae6749ec508e1c3ff5f04a483bb...