Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2320023003: [WIP] compare test cases (Closed)

Created:
4 years, 3 months ago by joone
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

compare test cases BUG=

Patch Set 1 : compare test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/editing/pasteboard/restore-collapsed-space-for-copy-test.html View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
joone
yosin@ could you take a look at two test cases? The first one was used ...
4 years, 3 months ago (2016-09-08 05:34:50 UTC) #4
yosin_UTC9
On 2016/09/08 at 05:34:50, joone.hur wrote: > yosin@ could you take a look at two ...
4 years, 3 months ago (2016-09-08 06:02:57 UTC) #5
joone
4 years, 3 months ago (2016-09-09 00:23:00 UTC) #6
On 2016/09/08 06:02:57, Yosi_UTC9 wrote:
> On 2016/09/08 at 05:34:50, joone.hur wrote:
> > yosin@ could you take a look at two test cases?
> > 
> > The first one was used in the previous CL that landed today. The second test
> case is the original one I wrote before using setClipboardData.
> > I think the result of two test cases should be the same, but they are
> different:
> > 
> > PASS 1. Restore the collapsed leading space
> > FAIL 2. Restore the collapsed leading space
>
LayoutTests/editing/pasteboard/restore-collapsed-space-for-copy-test.html:15:12)
> >          expected <div style="width: 2em;"><b><i>foo</i></b> bar</div><div
> contenteditable id="editor"><b><i>foo</i></b>&nbsp;bar|</div>,
> >          but got  <div style="width: 2em;"><b><i>foo</i></b> bar</div><div
> contenteditable id="editor"><b><i>foo</i></b>bar|</div>,
> >          sameupto <div style="width: 2em;"><b><i>foo</i></b> bar</div><div
> contenteditable id="editor"><b><i>foo</i></b>
> > 
> > It seems to be inappropriate to use setClipboardData in the test case
because
> it doesn't consider the parent layout(<div style="width: 2em;">).
> 
> Result is different since clipboard data are different. The space is yield by
> <span class="Apple-converted-space">\u{00A0}</span>bar
> 
> With "width: 2em"
> <b style="color: rgb(0, 0, 0); font-family: &quot;Times New Roman&quot;;
> font-size: medium; font-style: normal; font-variant-ligatures: normal;
> font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align:
> start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2;
> word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i>foo</i></b><span
> style="color: rgb(0, 0, 0); font-family: &quot;Times New Roman&quot;;
font-size:
> medium; font-style: normal; font-variant-ligatures: normal; font-variant-caps:
> normal; font-weight: normal; letter-spacing: normal; orphans: 2; text-align:
> start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2;
> word-spacing: 0px; -webkit-text-stroke-width: 0px; display: inline !important;
> float: none;">bar</span>
> 
> 
> With "width: 2em"
> <b style="color: rgb(0, 0, 0); font-family: &quot;Times New Roman&quot;;
> font-size: medium; font-style: normal; font-variant-ligatures: normal;
> font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align:
> start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2;
> word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i>foo</i></b><span
> style="color: rgb(0, 0, 0); font-family: &quot;Times New Roman&quot;;
font-size:
> medium; font-style: normal; font-variant-ligatures: normal; font-variant-caps:
> normal; font-weight: normal; letter-spacing: normal; orphans: 2; text-align:
> start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2;
> word-spacing: 0px; -webkit-text-stroke-width: 0px; display: inline !important;
> float: none;"><span class="Apple-converted-space">\u{00A0}</span>bar</span>

I think we still need the old test case that doesn't use setClipboardData
because it fails in layout test.
I'm working on it: https://codereview.chromium.org/2325553002/

Also, we need to investigate if the leading space is collapsed in the new test
case.

Powered by Google App Engine
This is Rietveld 408576698