Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6129)

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_delegate.cc

Issue 2320013003: [Extensions] Add UMA for the proxy override bubble (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/proxy_overridden_bubble_delegate.cc
diff --git a/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc b/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc
index 684ed5cc7e9e3f70e96421e89b4f6cabf6e65f48..32715d5790f4cc45d64c4a089a07d1d855bfe3f8 100644
--- a/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc
+++ b/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc
@@ -133,12 +133,11 @@ bool ProxyOverriddenBubbleDelegate::ShouldLimitToEnabledExtensions() const {
}
void ProxyOverriddenBubbleDelegate::LogExtensionCount(size_t count) {
- UMA_HISTOGRAM_COUNTS_100("ProxyOverriddenBubble.ExtensionCount", count);
Devlin 2016/09/08 22:09:32 This bubble is limited to a single extension, so t
Mark P 2016/09/08 22:55:25 Please add this histogram with an appropriate desc
Devlin 2016/09/08 23:13:36 Done.
}
void ProxyOverriddenBubbleDelegate::LogAction(
ExtensionMessageBubbleController::BubbleAction action) {
- UMA_HISTOGRAM_ENUMERATION("ProxyOverriddenBubble.UserSelection",
Mark P 2016/09/08 22:55:25 Please add this old histogram, optionally with an
Devlin 2016/09/08 23:13:36 As discussed offline, since retroactively adding t
+ UMA_HISTOGRAM_ENUMERATION("ExtensionBubble.ProxyUserSelection",
action,
ExtensionMessageBubbleController::ACTION_BOUNDARY);
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698