[Extensions] Add UMA for the proxy override bubble

chrome/browser/extensions/proxy_overridden_bubble_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/proxy_overridden_bubble_delegate.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/settings_api_helpers.h"
@@ skipping 115 matching lines @@
 
 bool ProxyOverriddenBubbleDelegate::ShouldHighlightExtensions() const {
   return true;
 }
 
 bool ProxyOverriddenBubbleDelegate::ShouldLimitToEnabledExtensions() const {
   return true;
 }
 
 void ProxyOverriddenBubbleDelegate::LogExtensionCount(size_t count) {
-  UMA_HISTOGRAM_COUNTS_100("ProxyOverriddenBubble.ExtensionCount", count);

[Devlin, 2016/09/08 22:09:32]

This bubble is limited to a single extension, so this histogram is unneeded.

[Mark P, 2016/09/08 22:55:25]

Please add this histogram with an appropriate description (describing its
problems) and an obsolete tag, otherwise perhaps someone hunting for histograms
to investigate something in the future will be misled.

[Devlin, 2016/09/08 23:13:36]

Done.

 }
 
 void ProxyOverriddenBubbleDelegate::LogAction(
     ExtensionMessageBubbleController::BubbleAction action) {
-  UMA_HISTOGRAM_ENUMERATION("ProxyOverriddenBubble.UserSelection",

[Mark P, 2016/09/08 22:55:25]

Please add this old histogram, optionally with an obsolete tag pointing to the
new one.  It's possible a user of the new one will wish they had more history
accessible, which is my the old one should be in histograms.xml.

[Devlin, 2016/09/08 23:13:36]

As discussed offline, since retroactively adding the entry to histograms.xml
will still have the data from before, added this histogram and still using this
name.

+  UMA_HISTOGRAM_ENUMERATION("ExtensionBubble.ProxyUserSelection",
                             action,
                             ExtensionMessageBubbleController::ACTION_BOUNDARY);
 }
 
 const char* ProxyOverriddenBubbleDelegate::GetKey() {
   return "ProxyOverriddenBubbleDelegate";
 }
 
 }  // namespace extensions