[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

components/sync/api/entity_data.h

Index: components/sync/api/entity_data.h
diff --git a/components/sync/api/entity_data.h b/components/sync/api/entity_data.h
index 99249471e7181bd1a33cfb14818b9198ee5d6292..09737dfac3011f214870ff53ce9998b0072055f1 100644
--- a/components/sync/api/entity_data.h
+++ b/components/sync/api/entity_data.h
@@ -11,6 +11,7 @@
 
 #include "base/macros.h"
 #include "base/time/time.h"
+#include "base/values.h"
 #include "components/sync/base/proto_value_ptr.h"
 #include "components/sync/protocol/sync.pb.h"
 
@@ -74,6 +75,10 @@ struct EntityData {
   // The return value must be assigned into another EntityDataPtr.
   EntityDataPtr PassToPtr() WARN_UNUSED_RESULT;
 
+  // Dumps all info into a DictionaryValue and returns it.
+  static std::unique_ptr<base::DictionaryValue> ToValue(

[skym, 2016/09/12 16:40:38]

Kinda odd that ToValue returns a DictionaryValue, right?

[pavely, 2016/09/12 20:43:04]

ToValue shouldn't be static. It is always called with valid reference to
EntityData and has the same access to fields as any member function. Could you
change it to non-static function?

[Gang Wu, 2016/09/12 22:38:03]

got this name from proto_value_conversions.cc, most of function named ...ToValue
and returns a DictionaryValue. how about change to ToDictionaryValue() ?

[Gang Wu, 2016/09/12 22:38:03]

Done.

+      const EntityData& entity_data);
+
  private:
   friend struct EntityDataTraits;
   // Used to transfer the data without copying.