[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

components/sync/api/entity_data.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_API_ENTITY_DATA_H_
 #define COMPONENTS_SYNC_API_ENTITY_DATA_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/time/time.h"
+#include "base/values.h"
 #include "components/sync/base/proto_value_ptr.h"
 #include "components/sync/protocol/sync.pb.h"
 
 namespace syncer_v2 {
 
 struct EntityData;
 
 struct EntityDataTraits {
   static void SwapValue(EntityData* dest, EntityData* src);
   static bool HasValue(const EntityData& value);
@@ skipping 43 matching lines @@
 
   // True if EntityData represents deleted entity; otherwise false.
   // Note that EntityData would be considered to represent a deletion if its
   // specifics hasn't been set.
   bool is_deleted() const { return specifics.ByteSize() == 0; }
 
   // Transfers this struct's data to EntityDataPtr.
   // The return value must be assigned into another EntityDataPtr.
   EntityDataPtr PassToPtr() WARN_UNUSED_RESULT;
 
+  // Dumps all info into a DictionaryValue and returns it.
+  static std::unique_ptr<base::DictionaryValue> ToValue(

[skym, 2016/09/12 16:40:38]

Kinda odd that ToValue returns a DictionaryValue, right?

[pavely, 2016/09/12 20:43:04]

ToValue shouldn't be static. It is always called with valid reference to
EntityData and has the same access to fields as any member function. Could you
change it to non-static function?

[Gang Wu, 2016/09/12 22:38:03]

got this name from proto_value_conversions.cc, most of function named ...ToValue
and returns a DictionaryValue. how about change to ToDictionaryValue() ?

[Gang Wu, 2016/09/12 22:38:03]

Done.

+      const EntityData& entity_data);
+
  private:
   friend struct EntityDataTraits;
   // Used to transfer the data without copying.
   void Swap(EntityData* other);
 
   DISALLOW_COPY_AND_ASSIGN(EntityData);
 };
 
 }  // namespace syncer_v2
 
 #endif  // COMPONENTS_SYNC_API_ENTITY_DATA_H_