Fixed touch offset for Blimp

Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
Committed: https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a
Cr-Commit-Position: refs/heads/master@{#417218}

[shaktisahu, 2016-09-07 21:40:56]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org, khushalsagar@chromium.org

[Khushal, 2016-09-07 22:15:57]

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2882:
lp.topMargin = (int) mFullscreenManager.getContentOffset();
You probably want to use getTopControlsHeight here. Does this work with
getContentOffset? Probably means we have a frame from the web content renderer
which set the value.

[David Trainor- moved to gerrit, 2016-09-07 22:35:57]

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2874: if
(getBlimpContents() != null && mFullscreenManager != null) {
Can you add a comment describing what we're doing here and why?

[shaktisahu, 2016-09-07 23:22:25]

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2874: if
(getBlimpContents() != null && mFullscreenManager != null) {
On 2016/09/07 22:35:57, David Trainor wrote:
> Can you add a comment describing what we're doing here and why?

Done.

https://codereview.chromium.org/2319913002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2882:
lp.topMargin = (int) mFullscreenManager.getContentOffset();
On 2016/09/07 22:15:57, Khushal wrote:
> You probably want to use getTopControlsHeight here. Does this work with
> getContentOffset? Probably means we have a frame from the web content renderer
> which set the value.

Changed to use getTopControlsHeight. Regarding the other comment about the order
of setFullscreenManager(), this will always be called after the tab has been
initialized and blimp contents has been created.

[shaktisahu, 2016-09-08 00:17:38]

dtrainor@, khushalsagar@ - PTAL

[Khushal, 2016-09-08 00:59:59]

https://codereview.chromium.org/2319913002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/2319913002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2881: if
(getBlimpContents() != null && mFullscreenManager != null) {
Can you also do this when we create the BlimpContents, be doubly sure.

[shaktisahu, 2016-09-08 01:35:06]

Description was changed from

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
==========

to

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
==========

[shaktisahu, 2016-09-08 01:35:07]

shaktisahu@chromium.org changed reviewers:
+ nyquist@chromium.org

[shaktisahu, 2016-09-08 02:19:00]

https://codereview.chromium.org/2319913002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/2319913002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:2881: if
(getBlimpContents() != null && mFullscreenManager != null) {
On 2016/09/08 00:59:59, Khushal wrote:
> Can you also do this when we create the BlimpContents, be doubly sure.

The BlimpContents is created inside the Tab.initialize() function which is the
first thing to be called after the tab is constructed. So, although both of the
methods are public, it kind of ensures proper initialization order so that blimp
view top margin will be set correctly.

[David Trainor- moved to gerrit, 2016-09-08 06:18:22]

lgtm

[shaktisahu, 2016-09-08 06:35:12]

The CQ bit was checked by shaktisahu@chromium.org

[commit-bot: I haz the power, 2016-09-08 06:35:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:23:49]

Description was changed from

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
==========

to

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
==========

[commit-bot: I haz the power, 2016-09-08 07:23:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 07:25:07]

Description was changed from

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417
==========

to

==========
Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417

Committed: https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a
Cr-Commit-Position: refs/heads/master@{#417218}
==========

[commit-bot: I haz the power, 2016-09-08 07:25:08]

Patchset 3 (id:??) landed as
https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a
Cr-Commit-Position: refs/heads/master@{#417218}