Fixed touch offset for Blimp

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.app.Activity;
 import android.app.Application;
 import android.content.Context;
 import android.content.Intent;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.Rect;
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.Handler;
 import android.os.Message;
 import android.provider.Browser;
 import android.text.TextUtils;
 import android.util.Log;
 import android.view.ContextThemeWrapper;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
-import android.view.ViewGroup.LayoutParams;
 import android.view.accessibility.AccessibilityEvent;
 import android.widget.FrameLayout;
+import android.widget.FrameLayout.LayoutParams;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.ObserverList;
 import org.chromium.base.ObserverList.RewindableIterator;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.TraceEvent;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
@@ skipping 2830 matching lines @@
             if (Float.isNaN(mPreviousFullscreenTopControlsOffsetY)
                     || Float.isNaN(mPreviousFullscreenContentOffsetY)) {
                 mFullscreenManager.setPositionsForTabToNonFullscreen();
             } else {
                 mFullscreenManager.setPositionsForTab(
                         mPreviousFullscreenTopControlsOffsetY, mPreviousFullscreenContentOffsetY);
             }
             mFullscreenManager.showControlsTransient();
             updateFullscreenEnabledState();
         }
+
+        // For blimp, set a top margin equal to the top controls height.
+        if (getBlimpContents() != null && mFullscreenManager != null) {

[Khushal, 2016/09/08 00:59:59]

Can you also do this when we create the BlimpContents, be doubly sure.

[shaktisahu, 2016/09/08 02:19:00]

The BlimpContents is created inside the Tab.initialize() function which is the
first thing to be called after the tab is constructed. So, although both of the
methods are public, it kind of ensures proper initialization order so that blimp
view top margin will be set correctly.

+            ViewGroup blimpView = getBlimpContents().getView();
+            FrameLayout.LayoutParams lp = (FrameLayout.LayoutParams) blimpView.getLayoutParams();
+            if (lp == null) {
+                lp = new FrameLayout.LayoutParams(
+                        LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
+            }
+
+            lp.topMargin = mFullscreenManager.getTopControlsHeight();
+            blimpView.setLayoutParams(lp);
+        }
     }
 
     /**
      * Add a new navigation entry for the current URL and page title.
      */
     void pushNativePageStateToNavigationEntry() {
         assert mNativeTabAndroid != 0 && getNativePage() != null;
         nativeSetActiveNavigationEntryTitleForUrl(mNativeTabAndroid, getNativePage().getUrl(),
                 getNativePage().getTitle());
     }
@@ skipping 433 matching lines @@
     private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
             InterceptNavigationDelegate delegate);
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native void nativeAttachOverlayWebContents(
             long nativeTabAndroid, WebContents webContents, boolean visible);
     private native void nativeDetachOverlayWebContents(
             long nativeTabAndroid, WebContents webContents);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
 }