Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2319763002: Fix "git cl set-commit" line in deps_updater.py. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "git cl set-commit" line in deps_updater.py. After running update-w3c-test-expectations, w3c-test-autoroller is now failing to run `git cl set-commit`. For example: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7496/steps/update%20wpt/logs/stdio After this, I'm expecting that it should update expectations/baselines, then try to commit, and then likely fail to pass the commit queue and abort. BUG=629275 Committed: https://crrev.com/7d9d7a102b1eb03414e366e540b27c680a480ca3 Cr-Commit-Position: refs/heads/master@{#417437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
qyearsley
4 years, 3 months ago (2016-09-07 18:37:30 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-08 22:03:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319763002/1
4 years, 3 months ago (2016-09-08 22:17:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:43:44 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:47:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9d7a102b1eb03414e366e540b27c680a480ca3
Cr-Commit-Position: refs/heads/master@{#417437}

Powered by Google App Engine
This is Rietveld 408576698