Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2319763002: Fix "git cl set-commit" line in deps_updater.py. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Fetches a copy of the latest state of a W3C test repository and commits. 5 """Fetches a copy of the latest state of a W3C test repository and commits.
6 6
7 If this script is given the argument --auto-update, it will also attempt to 7 If this script is given the argument --auto-update, it will also attempt to
8 upload a CL, triggery try jobs, and make any changes that are required for 8 upload a CL, triggery try jobs, and make any changes that are required for
9 new failing tests before committing. 9 new failing tests before committing.
10 """ 10 """
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 'upload', '-f', '--rietveld', 297 'upload', '-f', '--rietveld',
298 '-m', 'W3C auto test import CL.\n\nTBR=qyearsley@chromium.org', 298 '-m', 'W3C auto test import CL.\n\nTBR=qyearsley@chromium.org',
299 ] + ['--cc=' + email for email in cc_list]) 299 ] + ['--cc=' + email for email in cc_list])
300 300
301 self.print_('## Triggering try jobs.') 301 self.print_('## Triggering try jobs.')
302 for try_bot in self.host.builders.all_try_builder_names(): 302 for try_bot in self.host.builders.all_try_builder_names():
303 self.git_cl.run(['try', '-b', try_bot]) 303 self.git_cl.run(['try', '-b', try_bot])
304 if self.git_cl.has_failing_try_results(): 304 if self.git_cl.has_failing_try_results():
305 self.write_test_expectations() 305 self.write_test_expectations()
306 306
307 self.run(['set-commit', '--rietveld']) 307 self.git_cl.run(['set-commit', '--rietveld'])
308 if self.git_cl.has_failing_try_results(): 308 if self.git_cl.has_failing_try_results():
309 self.print_('## CL has failing results when trying to land; aborting .') 309 self.print_('## CL has failing results when trying to land; aborting .')
310 self.git_cl.run(['set-close']) 310 self.git_cl.run(['set-close'])
311 return False 311 return False
312 return True 312 return True
313 313
314 def get_directory_owners_to_cc(self): 314 def get_directory_owners_to_cc(self):
315 """Returns a list of email addresses to CC for the current import.""" 315 """Returns a list of email addresses to CC for the current import."""
316 self.print_('## Gathering directory owners emails to CC.') 316 self.print_('## Gathering directory owners emails to CC.')
317 directory_owners_file_path = self.finder.path_from_webkit_base( 317 directory_owners_file_path = self.finder.path_from_webkit_base(
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 email_addresses.add(directory_to_owner[test_dir]) 352 email_addresses.add(directory_to_owner[test_dir])
353 return sorted(email_addresses) 353 return sorted(email_addresses)
354 354
355 def write_test_expectations(self): 355 def write_test_expectations(self):
356 self.print_('## Adding test expectations lines to LayoutTests/TestExpect ations.') 356 self.print_('## Adding test expectations lines to LayoutTests/TestExpect ations.')
357 script_path = self.path_from_webkit_base('Tools', 'Scripts', 'update-w3c -test-expectations') 357 script_path = self.path_from_webkit_base('Tools', 'Scripts', 'update-w3c -test-expectations')
358 self.run([self.host.executable, script_path]) 358 self.run([self.host.executable, script_path])
359 message = '\'Modifies TestExpectations and/or downloads new baselines fo r tests\'' 359 message = '\'Modifies TestExpectations and/or downloads new baselines fo r tests\''
360 self.check_run(['git', 'commit', '-a', '-m', message]) 360 self.check_run(['git', 'commit', '-a', '-m', message])
361 self.git_cl.run(['upload', '-m', message, '--rietveld']) 361 self.git_cl.run(['upload', '-m', message, '--rietveld'])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698