Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2319603002: Hide "Format device" button in notification of unknown device when it is read only. (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Hide "Format device" button in notification of unknown device when it is read only. BUG=644043, 643475 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2310783004 Cr-Commit-Position: refs/heads/master@{#416576} (cherry picked from commit 5c3efcf062d49a2585fc3be33286e91118cd7efc)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M ui/file_manager/file_manager/background/js/device_handler.js View 2 chunks +19 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler_unittest.js View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fukino
lgtm
4 years, 3 months ago (2016-09-08 00:47:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319603002/1
4 years, 3 months ago (2016-09-08 01:54:36 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-08 01:54:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319603002/1
4 years, 3 months ago (2016-09-08 05:35:23 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:45:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698