Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2310783004: Hide "Format device" button in notification of unknown device when it is read only. (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide "Format device" button in notification of unknown device when it is read only. BUG=644043 Committed: https://crrev.com/5c3efcf062d49a2585fc3be33286e91118cd7efc Cr-Commit-Position: refs/heads/master@{#416576}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M ui/file_manager/file_manager/background/js/device_handler.js View 1 2 chunks +19 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler_unittest.js View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yamaguchi
4 years, 3 months ago (2016-09-05 13:55:35 UTC) #3
fukino
lgtm with nits. https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manager/background/js/device_handler.js File ui/file_manager/file_manager/background/js/device_handler.js (right): https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manager/background/js/device_handler.js#newcode405 ui/file_manager/file_manager/background/js/device_handler.js:405: DeviceHandler.Notification.DEVICE_FAIL_UNKNOWN_READONLY.show( indent should be 2 spaces ...
4 years, 3 months ago (2016-09-06 00:38:07 UTC) #8
yamaguchi
https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manager/background/js/device_handler.js File ui/file_manager/file_manager/background/js/device_handler.js (right): https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manager/background/js/device_handler.js#newcode405 ui/file_manager/file_manager/background/js/device_handler.js:405: DeviceHandler.Notification.DEVICE_FAIL_UNKNOWN_READONLY.show( On 2016/09/06 00:38:07, fukino wrote: > indent should ...
4 years, 3 months ago (2016-09-06 01:41:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310783004/20001
4 years, 3 months ago (2016-09-06 01:41:53 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 02:17:02 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 02:19:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c3efcf062d49a2585fc3be33286e91118cd7efc
Cr-Commit-Position: refs/heads/master@{#416576}

Powered by Google App Engine
This is Rietveld 408576698