Hide "Format device" button in notification of unknown device when it is read only.

Hide "Format device" button in notification of unknown device when it is read only.

BUG=644043
Committed: https://crrev.com/5c3efcf062d49a2585fc3be33286e91118cd7efc
Cr-Commit-Position: refs/heads/master@{#416576}

[yamaguchi, 2016-09-05 13:52:01]

Description was changed from

==========
Stop showing "Format device" button when the device is read only.

BUG=644043
==========

to

==========
Hide "Format device" button in notification of unknown device when it is read
only.

BUG=644043
==========

[yamaguchi, 2016-09-05 13:52:01]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2016-09-05 13:55:49]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 13:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 14:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 14:38:57]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-09-06 00:38:07]

lgtm with nits.

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/device_handler.js:405:
DeviceHandler.Notification.DEVICE_FAIL_UNKNOWN_READONLY.show(
indent should be 2 spaces rather than 4 spaces.

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/device_handler.js:410: /** @type
{string} */ (volume.devicePath),
indent level should be 4 spaces rather than 6 spaces

[yamaguchi, 2016-09-06 01:41:03]

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/device_handler.js:405:
DeviceHandler.Notification.DEVICE_FAIL_UNKNOWN_READONLY.show(
On 2016/09/06 00:38:07, fukino wrote:
> indent should be 2 spaces rather than 4 spaces.

Done.

https://codereview.chromium.org/2310783004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/device_handler.js:410: /** @type
{string} */ (volume.devicePath),
On 2016/09/06 00:38:07, fukino wrote:
> indent level should be 4 spaces rather than 6 spaces

Done.

[yamaguchi, 2016-09-06 01:41:41]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2016-09-06 01:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2310783004/#ps20001
(title: "Fix indent.")

[commit-bot: I haz the power, 2016-09-06 01:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 02:17:01]

Description was changed from

==========
Hide "Format device" button in notification of unknown device when it is read
only.

BUG=644043
==========

to

==========
Hide "Format device" button in notification of unknown device when it is read
only.

BUG=644043
==========

[commit-bot: I haz the power, 2016-09-06 02:17:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 02:19:17]

Description was changed from

==========
Hide "Format device" button in notification of unknown device when it is read
only.

BUG=644043
==========

to

==========
Hide "Format device" button in notification of unknown device when it is read
only.

BUG=644043

Committed: https://crrev.com/5c3efcf062d49a2585fc3be33286e91118cd7efc
Cr-Commit-Position: refs/heads/master@{#416576}
==========

[commit-bot: I haz the power, 2016-09-06 02:19:18]

Patchset 2 (id:??) landed as
https://crrev.com/5c3efcf062d49a2585fc3be33286e91118cd7efc
Cr-Commit-Position: refs/heads/master@{#416576}