Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2319533004: Removed m_isSettingStyleSheetText from InspectorCSSAgent. (Closed)

Created:
4 years, 3 months ago by rune
Modified:
4 years, 3 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, tfarina, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed m_isSettingStyleSheetText from InspectorCSSAgent. The variable supressed an unnecessary re-collection of inspector stylesheets when the stylesheet text is modified from the inspector. If the text added contains an @import rule with a data: uri, it also suppresses the collection of that sheet, which is wrong. R=pfeldman@chromium.org,lushnikov@chromium.org BUG=644719 Committed: https://crrev.com/4ed808a8d879f01d673eb1bc6d8f8691a58a28cb Cr-Commit-Position: refs/heads/master@{#417290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -28 lines) Patch
A third_party/WebKit/LayoutTests/inspector/elements/styles-2/add-import-rule.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles-2/add-import-rule-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
rune
ptal
4 years, 3 months ago (2016-09-08 06:16:04 UTC) #6
lushnikov
thanks, lgtm
4 years, 3 months ago (2016-09-08 14:30:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319533004/1
4 years, 3 months ago (2016-09-08 14:36:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:40:44 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:42:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ed808a8d879f01d673eb1bc6d8f8691a58a28cb
Cr-Commit-Position: refs/heads/master@{#417290}

Powered by Google App Engine
This is Rietveld 408576698