Issue 2312953002: Store a single inspector stylesheet hidden from CSSOM.

rune

The CQ bit was checked by rune@opera.com to run a CQ dry run

4 years, 3 months ago (2016-09-06 15:25:57 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312953002/1

4 years, 3 months ago (2016-09-06 15:26:22 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-06 16:54:46 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/287901)

4 years, 3 months ago (2016-09-06 16:54:46 UTC) #4

rune

The CQ bit was checked by rune@opera.com to run a CQ dry run

4 years, 3 months ago (2016-09-06 22:07:11 UTC) #5

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312953002/20001

4 years, 3 months ago (2016-09-06 22:07:34 UTC) #6

rune

ptal https://codereview.chromium.org/2312953002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (left): https://codereview.chromium.org/2312953002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#oldcode1792 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1792: m_documentToViaInspectorStyleSheet.remove(document); Should I just remove the didRemoveDocument method ...

4 years, 3 months ago (2016-09-06 22:36:48 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-06 23:31:16 UTC) #8

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 3 months ago (2016-09-06 23:31:17 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312953002/20001

4 years, 3 months ago (2016-09-07 19:09:13 UTC) #12

commit-bot: I haz the power

Description was changed from ========== Store a single inspector stylesheet hidden from CSSOM. Custom style ...

4 years, 3 months ago (2016-09-07 19:17:22 UTC) #14

Message was sent while issue was closed.

Description was changed from

==========
Store a single inspector stylesheet hidden from CSSOM.

Custom style rules can be added via the inspector. These were stored in
a stylesheet appended to <head>. That meant it was visible to the
document via CSSOM. Also, enabling/disabling the inspector would not
remember that a stylesheet was added, so the inspector started out with
a new blank stylesheet for editing, yet the existing rules still
applied.

This CL introduces a single inspector stylesheet in the StyleEngine
which takes part in the document collection to apply the rules, but it
is not appended to the document.styleSheets list. Neither is it
accessible through a <style> element in the DOM.

The stylesheet ends up after the author stylesheets in the order of
appearance. That is similar to how it was, but previously, sheets in
<body> would appear after the inspector sheet while sheets in <head>
would appear before.

The inspector sheet source is stored in a resource container like
changes for author stylesheets. This means the inspector sheet source
will persist across inspector enable/disable.

R=pfeldman@chromium.org,lushnikov@chromium.org
BUG=624139
TEST=http/tests/inspector-enabled/reattach-after-editing-styles.html
==========

to

==========
Store a single inspector stylesheet hidden from CSSOM.

Custom style rules can be added via the inspector. These were stored in
a stylesheet appended to <head>. That meant it was visible to the
document via CSSOM. Also, enabling/disabling the inspector would not
remember that a stylesheet was added, so the inspector started out with
a new blank stylesheet for editing, yet the existing rules still
applied.

This CL introduces a single inspector stylesheet in the StyleEngine
which takes part in the document collection to apply the rules, but it
is not appended to the document.styleSheets list. Neither is it
accessible through a <style> element in the DOM.

The stylesheet ends up after the author stylesheets in the order of
appearance. That is similar to how it was, but previously, sheets in
<body> would appear after the inspector sheet while sheets in <head>
would appear before.

The inspector sheet source is stored in a resource container like
changes for author stylesheets. This means the inspector sheet source
will persist across inspector enable/disable.

R=pfeldman@chromium.org,lushnikov@chromium.org
BUG=624139
TEST=http/tests/inspector-enabled/reattach-after-editing-styles.html

Committed: https://crrev.com/af38b2ad3019b41ee420097c6d81a5cebda7dadc
Cr-Commit-Position: refs/heads/master@{#417021}
==========

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/af38b2ad3019b41ee420097c6d81a5cebda7dadc Cr-Commit-Position: refs/heads/master@{#417021}

4 years, 3 months ago (2016-09-07 19:17:23 UTC) #15

Message was sent while issue was closed.

thank you for the patch, lgtm

Issue 2312953002: Store a single inspector stylesheet hidden from CSSOM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Incorrect removal. #

Messages