Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 652ddc27e75c5e2ff2cdfb6c048271b470bac1ae..22e57534deb93cdf70d3c288bfaad360a7ca5500 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -244,8 +244,10 @@ class ContentViewCoreImpl : public ContentViewCore,
// |multiple| defines if it should support multi-select.
// If not |multiple|, |selected_item| sets the initially selected item.
// Otherwise, item's "checked" flag selects it.
- void ShowSelectPopupMenu(const std::vector<MenuItem>& items,
+ void ShowSelectPopupMenu(const gfx::Rect& bounds,
+ const std::vector<MenuItem>& items,
int selected_item,
+ double item_font_size,
Ted C 2014/04/12 01:10:27 In my opinion, we should not use the font size but
keishi 2014/04/15 14:41:07 I've asked sgabriel@ if he wants the popup font si
bool multiple);
// Hides a visible popup menu.
void HideSelectPopupMenu();
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698