Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: content/browser/android/content_view_core_impl.h

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // -------------------------------------------------------------------------- 237 // --------------------------------------------------------------------------
238 // Public methods that call to Java via JNI 238 // Public methods that call to Java via JNI
239 // -------------------------------------------------------------------------- 239 // --------------------------------------------------------------------------
240 240
241 void OnSmartClipDataExtracted(const base::string16& result); 241 void OnSmartClipDataExtracted(const base::string16& result);
242 242
243 // Creates a popup menu with |items|. 243 // Creates a popup menu with |items|.
244 // |multiple| defines if it should support multi-select. 244 // |multiple| defines if it should support multi-select.
245 // If not |multiple|, |selected_item| sets the initially selected item. 245 // If not |multiple|, |selected_item| sets the initially selected item.
246 // Otherwise, item's "checked" flag selects it. 246 // Otherwise, item's "checked" flag selects it.
247 void ShowSelectPopupMenu(const std::vector<MenuItem>& items, 247 void ShowSelectPopupMenu(const gfx::Rect& bounds,
248 const std::vector<MenuItem>& items,
248 int selected_item, 249 int selected_item,
250 double item_font_size,
Ted C 2014/04/12 01:10:27 In my opinion, we should not use the font size but
keishi 2014/04/15 14:41:07 I've asked sgabriel@ if he wants the popup font si
249 bool multiple); 251 bool multiple);
250 // Hides a visible popup menu. 252 // Hides a visible popup menu.
251 void HideSelectPopupMenu(); 253 void HideSelectPopupMenu();
252 254
253 void OnTabCrashed(); 255 void OnTabCrashed();
254 256
255 // All sizes and offsets are in CSS pixels as cached by the renderer. 257 // All sizes and offsets are in CSS pixels as cached by the renderer.
256 void UpdateFrameInfo(const gfx::Vector2dF& scroll_offset, 258 void UpdateFrameInfo(const gfx::Vector2dF& scroll_offset,
257 float page_scale_factor, 259 float page_scale_factor,
258 const gfx::Vector2dF& page_scale_factor_limits, 260 const gfx::Vector2dF& page_scale_factor_limits,
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 bool geolocation_needs_pause_; 408 bool geolocation_needs_pause_;
407 409
408 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl); 410 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
409 }; 411 };
410 412
411 bool RegisterContentViewCore(JNIEnv* env); 413 bool RegisterContentViewCore(JNIEnv* env);
412 414
413 } // namespace content 415 } // namespace content
414 416
415 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 417 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698