chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java - Issue 231953003: Show Ash like <select> popup on Android tablets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

index d6b4a36a5a49848d3a8d276fbe0dff364b71a885..6e696f75ba4f5ed24cdc053d1d2bbf3d6d3118b6 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

@@ -171,7 +171,7 @@ public class AutofillPopupTest extends ChromeShellTestBase {

});

waitForAnchorViewAdd(view);

- View anchorView = view.findViewById(R.id.autofill_popup_window);

+ View anchorView = view.findViewById(R.id.dropdown_popup_window);

assertTrue(anchorView.getTag() instanceof AutofillPopup);

final AutofillPopup popup = (AutofillPopup) anchorView.getTag();

@@ -306,7 +306,7 @@ public class AutofillPopupTest extends ChromeShellTestBase {

CriteriaHelper.pollForCriteria(new Criteria() {

@Override

public boolean isSatisfied() {

- return view.findViewById(R.id.autofill_popup_window) != null;

+ return view.findViewById(R.id.dropdown_popup_window) != null;

}

}));

}