chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java - Issue 231953003: Show Ash like <select> popup on Android tablets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwAutofillManagerDelegate.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

index 7c033b9fa1660a287e72608d0fa1416249ee3913..a0dd09bc5253231a95feba214ad2e19bbcc1c824 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

@@ -74,7 +74,7 @@ public class AutofillPopupBridge implements AutofillPopupDelegate{

@CalledByNative

private void show(AutofillSuggestion[] suggestions) {

- if (mAutofillPopup != null) mAutofillPopup.show(suggestions);

+ if (mAutofillPopup != null) mAutofillPopup.filterAndShow(suggestions);

}

/**